Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apt keyring installation #41307

Merged
merged 2 commits into from May 26, 2023
Merged

Update apt keyring installation #41307

merged 2 commits into from May 26, 2023

Conversation

MaKraMc
Copy link
Contributor

@MaKraMc MaKraMc commented May 24, 2023

The plain google signing key for apt does not work anymore. It needs to be "deamord" using gpg.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 24, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MaKraMc / name: Marco Kraft (cf11bcd)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MaKraMc!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 24, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 24, 2023
@netlify
Copy link

netlify bot commented May 24, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b340608
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/646e2f736bc777000870fc5a
😎 Deploy Preview https://deploy-preview-41307--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced May 24, 2023
Closed
Closed
@sftim
Copy link
Contributor

sftim commented May 24, 2023

/sig release

Is this the right change to make?

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label May 24, 2023
@sftim
Copy link
Contributor

sftim commented May 24, 2023

/hold

SIG Release: feel free to unhold once this has an appropriate tech review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@MaKraMc @sftim
Update content/en/docs/setup/production-environment/tools/kubeadm/ins…
b340608 
…tall-kubeadm.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>
saschagrunert
saschagrunert approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good from the SIG Release side. Thank you!

@saschagrunert
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
sftim
sftim reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe68b95852f1281ccc88e11ec1e0fc74c50edb6a

@sftim sftim mentioned this pull request May 25, 2023
Closed
@yuval-k yuval-k mentioned this pull request May 25, 2023
Closed
@tengqm
Copy link
Contributor

tengqm commented May 26, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 31bb79f into kubernetes:main May 26, 2023
7 checks passed
This was referenced May 26, 2023
Merged
Closed
Closed
@dipesh-rawat dipesh-rawat mentioned this pull request May 26, 2023
Closed
neolit123
neolit123 reviewed May 26, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be backported to the website branches in skew?

@sftim
Copy link
Contributor

sftim commented May 26, 2023

should this be backported to the website branches in skew?

It can be. General SIG Docs policy is to actively maintain only main. I think an exception here makes sense.

This was referenced May 27, 2023
Closed
Merged
Merged
Merged
Merged
@HollowMan6 HollowMan6 mentioned this pull request Jun 6, 2023
Merged
@MaKraMc MaKraMc deleted the patch-1 branch January 23, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@sftim sftim sftim left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@natalisucks natalisucks Awaiting requested review from natalisucks

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MaKraMc @k8s-ci-robot @sftim @saschagrunert @tengqm @neolit123