Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify recommended Windows hardware requirements #42518

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Specify recommended Windows hardware requirements #42518

merged 1 commit into from
Feb 15, 2024

Conversation

tzifudzi
Copy link
Contributor

@tzifudzi tzifudzi commented Aug 12, 2023 •
edited
Loading

What will change

  • Added a new section specifying minimum recommended hardware requirements for Windows worker nodes

Why this change is necessary?

  • Part of Overhaul Windows documentation #31428 issue to add improvements to the windows documentation
  • Listing system requirements for Windows will help guide users properly setup their Windows worker nodes, as there are a few caveats and differences compared to Linux.

Documentation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 12, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @tzifudzi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2023
@netlify
Copy link

netlify bot commented Aug 12, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f92b564
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65cda2a1ce78cc0008831ed5
😎 Deploy Preview https://deploy-preview-42518--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tzifudzi tzifudzi mentioned this pull request Aug 13, 2023
Closed
9 tasks
@kbhawkey
Copy link
Contributor

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Dec 20, 2023
@kbhawkey
Copy link
Contributor

Hello @tzifudzi .
Are you actively working on your pull request or do you have questions?
Thanks

@tzifudzi tzifudzi force-pushed the windows-hardware-requirements branch from 0aea3b8 to 4cef251 Compare December 21, 2023 05:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@tzifudzi tzifudzi force-pushed the windows-hardware-requirements branch from 4cef251 to 5c444a1 Compare December 21, 2023 05:41
@tzifudzi tzifudzi marked this pull request as ready for review December 21, 2023 05:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2023
@tzifudzi
Copy link
Contributor Author

Hi @kbhawkey. PR is ready for review. I also applied your suggestion to format the README so that the paraphs stick within the line character limit.

@kbhawkey
Copy link
Contributor

Ping Sig Windows for technical review

/sig windows

@marosset
Copy link
Contributor

marosset commented Jan 2, 2024

@tzifudzi - Are we seeing cases where people are running into issues with running Windows workloads in Kubernetes specifically because their nodes don't have enough resources?

If that is the case perhaps we should add or link to docs that can help easily identify these sorts of issues?

@tzifudzi
Copy link
Contributor Author

tzifudzi commented Jan 9, 2024 •
edited
Loading

Are we seeing cases where people are running into issues with running Windows workloads in Kubernetes specifically because their nodes don't have enough resources?

To my knowledge, there haven't been cases of issues specifically linked to inadequate resources for Windows workloads on Kubernetes. The recommendation to update the documentation I can't recall but I think it originated from the sig-docs team, as reflected in the creation of the parent issue (#31428) that you own. This documentation addresses one of the tasks outlined in that issue. Specify minimum or recommended system requirements

@marosset If we feel the documentation is unnecessary I am ok with closing the issue, but what I suggest is merging, but I can remove the explicit info I specified which could become stale.

aravindhp
aravindhp reviewed Jan 9, 2024
View reviewed changes
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
@tzifudzi tzifudzi force-pushed the windows-hardware-requirements branch from b4359be to 21df181 Compare January 30, 2024 05:50
@tzifudzi tzifudzi force-pushed the windows-hardware-requirements branch from 21df181 to 3ed6fad Compare January 30, 2024 06:00
aravindhp
aravindhp reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsturtevant
jsturtevant approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mloskot
mloskot approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzifudzi tzifudzi requested a review from tengqm February 7, 2024 01:42
@tzifudzi
Copy link
Contributor Author

tzifudzi commented Feb 7, 2024

@tengqm @kbhawkey I have finished getting technical review from sig-windows folks. Can I please get a review from either one you (or both) as well?

marosset
marosset reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d87ac72d7ab28282d5625ffa156a0c243812d1f9

@tzifudzi tzifudzi force-pushed the windows-hardware-requirements branch from 3ed6fad to 45e961a Compare February 15, 2024 05:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024
@tzifudzi tzifudzi force-pushed the windows-hardware-requirements branch from 45e961a to f92b564 Compare February 15, 2024 05:35
@reylejano
Copy link
Member

Thank you for addressing comments
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb82ddd6d7a3e5b0e9d54589793a25aeaa227850

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, mloskot, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit a6a613d into kubernetes:main Feb 15, 2024
6 checks passed
@windsonsea windsonsea mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@aravindhp aravindhp aravindhp left review comments

@mloskot mloskot mloskot approved these changes

@jsturtevant jsturtevant jsturtevant approved these changes

@perithompson perithompson Awaiting requested review from perithompson

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@tengqm tengqm Awaiting requested review from tengqm

@marosset marosset Awaiting requested review from marosset

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@marosset marosset

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tzifudzi @k8s-ci-robot @kbhawkey @marosset @mloskot @reylejano @jsturtevant @tengqm @aravindhp