improve: Update alt attributes for images on the front page #43088
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/area web-development |
k8s-ci-robot
added
the
area/web-development
There was a problem hiding this comment.
Thank you for your contribution! Just noticed that most of the images now have empty alt attributes, which is great. However, there are still a few images remaining that seem to be generated from the 'case-studies' shortcode. To address this, you can navigate to the 'case-studies.html' file (specifically to line 16) and make a similar change. Once that's done, we should be all set.
Also, you can verify the changes through the Preview Link - https://deploy-preview-43088--kubernetes-io-main-staging.netlify.app/ .
|
Thank you, @dipesh-rawat for your guidance and assistance! Your help has been great. |
| @@ -13,7 +13,7 @@ <h3>{{ $caseStudiesSection.Title }}</h3> | |||
| {{ $logo = .Resources.GetMatch "**logo*.png" }} | |||
| {{ end }} | |||
| <div> | |||
| {{ with $logo }}<img src="{{ .RelPermalink }}" alt="{{ .Title }}">{{ end }} | |||
| {{ with $logo }}<img src="{{ .RelPermalink }}" alt="">{{ end }} | |||
There was a problem hiding this comment.
I believe this alt attributes are there to improve accessibility.
|
/close |
|
@tengqm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@tengqm: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0d44ce7a1b99e66ba0d578bd51c1beb485dfad9a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…es#43088) * improve: Update alt attributes for images on the front page * case studies image alt attribute * Update case-studies.html
Lots of the images on the front page of the Kubernetes website (https://kubernetes.io/) have unhelpful alt attributes, such as the filename. This commit addresses this issue by updating the alt attributes with the empty string.
#42832