Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs update for Job Backoff Limit Per Index in Beta #43388

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Docs update for Job Backoff Limit Per Index in Beta #43388

merged 1 commit into from
Nov 7, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 9, 2023

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7373138
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6548a81c52d021000879205b

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 9, 2023
@mimowo mimowo changed the title Docs update for Job Backoff Limit Per Index in Beta WIP: Docs update for Job Backoff Limit Per Index in Beta [placeholder] Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@sftim
Copy link
Contributor

sftim commented Oct 9, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 9, 2023
@jensentanlo jensentanlo mentioned this pull request Oct 19, 2023
Open
8 tasks
@katcosgrove
Copy link
Contributor

Hi, @mimowo! v1.29 Docs Lead here. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@mimowo mimowo changed the title WIP: Docs update for Job Backoff Limit Per Index in Beta [placeholder] Docs update for Job Backoff Limit Per Index in Beta Nov 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index-beta branch from 1636b06 to 3401b4c Compare November 3, 2023 17:21
@mimowo
Copy link
Contributor Author

mimowo commented Nov 3, 2023 •
edited
Loading

/assign @alculquicondor @sftim
Minimal changes for now, but there are no changes / bugfixes since 1.28 (alpha). We could consider adding a tasks page as planned before for alpha, but would like to hear opinions of others before doing.

@alculquicondor
Copy link
Member

I don't think it's worth adding a task page just for this feature.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a8719e6f2fe5d1f8777a1719bbace223967a5210

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index-beta branch from 20621d5 to 7373138 Compare November 6, 2023 08:47
@tengqm
Copy link
Contributor

tengqm commented Nov 7, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d62862cd2bd2a212c42e764f3e2f9c83a6861f23

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7fe30f5 into kubernetes:dev-1.29 Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@soltysh soltysh Awaiting requested review from soltysh

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@sftim sftim Awaiting requested review from sftim

Assignees

@alculquicondor alculquicondor

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mimowo @sftim @katcosgrove @alculquicondor @k8s-ci-robot @tengqm