Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace kubepkg reference with krel templates #43409

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Replace kubepkg reference with krel templates #43409

merged 1 commit into from
Oct 11, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 10, 2023 •
edited

The krel templates are the ones we use right now, while kubepkg got removed in kubernetes/release#3313.

/cc @kubernetes/release-managers

@saschagrunert
Replace kubepkg reference with krel templates
d02dbb4 
The `krel` templates are the ones we use right now, while kubepkg got
removed in kubernetes/release#3313.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-managers.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The krel templates are the ones we use right now, while kubepkg got removed in kubernetes/release#3313.
/cc @kubernetes/release-managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 10, 2023
@saschagrunert saschagrunert mentioned this pull request Oct 10, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2023
xmudrii
xmudrii approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d65c097db2c80bf8c26b3fd73918e3a6534a46f

@netlify
Copy link

netlify bot commented Oct 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d02dbb4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65254887b893210008b90e04
😎 Deploy Preview https://deploy-preview-43409--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

windsonsea
windsonsea approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, windsonsea, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4440dba into kubernetes:main Oct 11, 2023
6 checks passed
@saschagrunert saschagrunert deleted the kubepkg branch October 11, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@windsonsea windsonsea windsonsea approved these changes

Assignees

@xmudrii xmudrii

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saschagrunert @k8s-ci-robot @tengqm @xmudrii @windsonsea