Improve Kubernetes tutorial around explaining Services #43503

javadebadi · 2023-10-16T04:32:05Z

In this tutorial section, it is assumed that the kubernetes-bootcamp service of type "LoadBalancer" exists. However, in previous section of the tutorial, a service of type "NodePort" is created and at end that section it is deleted. It can make users confused about what kind of service is currently created in this section of the document.

I added these lines to make it clear that we have to create a service of type "LoadBalancer" and I also added the command to make this happen.

linux-foundation-easycla · 2023-10-16T04:32:11Z

The committers listed above are authorized under a signed CLA.

✅ login: javadebadi / name: Javad Ebadi (fde9de4, 4e68710, fd7c1c6, 0f64e2d, a2e7674, 067b688, b371ed0, 333454d)

k8s-ci-robot · 2023-10-16T04:32:14Z

Welcome @javadebadi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2023-10-16T04:35:08Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`067b688`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/660aaa733b1c540008c4d281
😎 Deploy Preview	https://deploy-preview-43503--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aj11anuj

(Some word replacements + Text wrapping + Cmd typo) needs to be fixed.

content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html

javadebadi · 2023-12-01T06:16:42Z

@aj11anuj

I added new changes based on your recommondations. Do you have other suggestions?

aj11anuj

/lgtm

k8s-ci-robot · 2023-12-07T14:24:10Z

LGTM label has been added.

Git tree hash: 37ea4bd10eccc90417b04baf69cfff8891f64274

sftim

Try this?

content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html

niranjandarshann · 2024-02-27T06:44:13Z

content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html

@@ -31,7 +31,14 @@ <h3>Scaling an application</h3>
            <p>If you haven't worked through the earlier sections, start from <a href="/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/">Using minikube to create a cluster</a>.</p>

            <p><em>Scaling</em> is accomplished by changing the number of replicas in a Deployment</p>
-            <p> <b> NOTE </b> If you are trying this after <a href="/docs/tutorials/kubernetes-basics/expose/expose-intro/">the previous section </a>, you may need to start from <a href="/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/">creating a cluster</a> as the services may have been deleted </p>
+            <p><b>NOTE</b> If you are trying this after <a href="/docs/tutorials/kubernetes-basics/expose/expose-intro/">the previous section </a>, then you
+            may have deleted the Sservice you created, or have created a Service of <tt>type: NodePort</tt>.


@javadebadi Did you mean service istaead of Sservice here.? If so please do the changes

@niranjandarshann Fixed the type

dipesh-rawat · 2024-03-04T01:01:30Z

@javadebadi Could you rebase this PR against the main branch when you get a chance?

divya-mohan0209 · 2024-04-01T03:52:58Z

@javadebadi : To proceed further, we need you to rebase the PR against the main branch. Please could you do that so that we can ready it for merge?

… have created a kuberentes-bootcamp service with LoadBalancer type

…html Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>

…html Co-authored-by: Tim Bannister <tim@scalefactory.com>

…html Rephrase Co-authored-by: Tim Bannister <tim@scalefactory.com>

Fixed typo: Sservice -> service

javadebadi · 2024-04-01T12:45:44Z

@dipesh-rawat @divya-mohan0209
Rebased this PR againts main branch

sftim · 2024-04-02T14:44:11Z

/retitle Improve Kubernetes tutorial around explaining Services

sftim

/lgtm

/label tide/merge-method-squash

k8s-ci-robot · 2024-04-02T14:44:52Z

LGTM label has been added.

Git tree hash: 2f44b954672837b6be6e02a442417931e86e1880

reylejano · 2024-04-26T16:01:44Z

/approve

k8s-ci-robot · 2024-04-26T16:02:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2023

k8s-ci-robot requested a review from sftim October 16, 2023 04:32

k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 16, 2023

k8s-ci-robot requested a review from windsonsea October 16, 2023 04:32

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 16, 2023

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 16, 2023

aj11anuj suggested changes Oct 17, 2023

View reviewed changes

aj11anuj reviewed Dec 7, 2023

View reviewed changes

k8s-ci-robot assigned aj11anuj Dec 7, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2023

sftim reviewed Dec 28, 2023

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024

k8s-ci-robot requested a review from aj11anuj January 10, 2024 06:30

javadebadi requested a review from sftim January 10, 2024 06:33

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024

niranjandarshann reviewed Feb 27, 2024

View reviewed changes

javadebadi and others added 5 commits April 1, 2024 06:34

Adds a new lines to documents explaining that this section assumes we…

0f64e2d

… have created a kuberentes-bootcamp service with LoadBalancer type

Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.…

fde9de4

…html Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>

Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.…

fd7c1c6

…html Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>

Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.…

b371ed0

…html Co-authored-by: Anuj Tiwari <aj11anuj123@gmail.com>

Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.…

333454d

…html Co-authored-by: Tim Bannister <tim@scalefactory.com>

javadebadi and others added 3 commits April 1, 2024 06:34

Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.…

4e68710

…html Co-authored-by: Tim Bannister <tim@scalefactory.com>

Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.…

a2e7674

…html Rephrase Co-authored-by: Tim Bannister <tim@scalefactory.com>

Update scale-intro.html

067b688

Fixed typo: Sservice -> service

javadebadi force-pushed the main branch from 1f35f79 to 067b688 Compare April 1, 2024 12:37

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2024

k8s-ci-robot changed the title ~~Adds new explanations to kuberentes tutorial expose section to make it clear what are the assumption about the service of the deployment~~ Improve Kubernetes tutorial around explaining Services Apr 2, 2024

sftim reviewed Apr 2, 2024

View reviewed changes

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 2, 2024

k8s-ci-robot assigned sftim Apr 2, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024

k8s-ci-robot merged commit f140892 into kubernetes:main Apr 26, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Kubernetes tutorial around explaining Services #43503

Improve Kubernetes tutorial around explaining Services #43503

javadebadi commented Oct 16, 2023

linux-foundation-easycla bot commented Oct 16, 2023 •

edited

Loading

k8s-ci-robot commented Oct 16, 2023

netlify bot commented Oct 16, 2023 •

edited

Loading

aj11anuj left a comment •

edited

Loading

javadebadi commented Dec 1, 2023

aj11anuj left a comment

k8s-ci-robot commented Dec 7, 2023

sftim left a comment

niranjandarshann Feb 27, 2024 •

edited

Loading

javadebadi Feb 27, 2024

dipesh-rawat commented Mar 4, 2024

divya-mohan0209 commented Apr 1, 2024

javadebadi commented Apr 1, 2024

sftim commented Apr 2, 2024

sftim left a comment

k8s-ci-robot commented Apr 2, 2024

reylejano commented Apr 26, 2024

k8s-ci-robot commented Apr 26, 2024

Improve Kubernetes tutorial around explaining Services #43503

Improve Kubernetes tutorial around explaining Services #43503

Conversation

javadebadi commented Oct 16, 2023

linux-foundation-easycla bot commented Oct 16, 2023 • edited Loading

k8s-ci-robot commented Oct 16, 2023

netlify bot commented Oct 16, 2023 • edited Loading

✅ Pull request preview available for checking

aj11anuj left a comment • edited Loading

Choose a reason for hiding this comment

javadebadi commented Dec 1, 2023

aj11anuj left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 7, 2023

sftim left a comment

Choose a reason for hiding this comment

niranjandarshann Feb 27, 2024 • edited Loading

Choose a reason for hiding this comment

javadebadi Feb 27, 2024

Choose a reason for hiding this comment

dipesh-rawat commented Mar 4, 2024

divya-mohan0209 commented Apr 1, 2024

javadebadi commented Apr 1, 2024

sftim commented Apr 2, 2024

sftim left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 2, 2024

reylejano commented Apr 26, 2024

k8s-ci-robot commented Apr 26, 2024

linux-foundation-easycla bot commented Oct 16, 2023 •

edited

Loading

netlify bot commented Oct 16, 2023 •

edited

Loading

aj11anuj left a comment •

edited

Loading

niranjandarshann Feb 27, 2024 •

edited

Loading