Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs to promote PodReadyToStartContainersCondition into beta #43533

Merged
merged 4 commits into from
Nov 27, 2023
Merged

update docs to promote PodReadyToStartContainersCondition into beta #43533

merged 4 commits into from
Nov 27, 2023

Conversation

charles-chenzz
Copy link
Member

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit a8d08be
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/655bf1aea1ceff00084077b3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@charles-chenzz charles-chenzz mentioned this pull request Oct 17, 2023
Open
20 tasks
@sftim
Copy link
Contributor

sftim commented Oct 17, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 17, 2023
@bart0sh bart0sh added this to WIP in SIG Node PR Triage Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@harshitasao
Copy link
Contributor

Hi @charles-chenzz , Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023.
Thank you!

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2023
@charles-chenzz charles-chenzz changed the title [WIP] [Placeholder] update docs to promote PodReadyToStartContainersCondition into beta update docs to promote PodReadyToStartContainersCondition into beta Nov 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@sftim
Copy link
Contributor

sftim commented Nov 13, 2023

Thanks

Please split the blog article into a separate PR that targets the main branch.

/hold
pending that happening

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
sftim
sftim previously requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to change https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ I think

@charles-chenzz
Copy link
Member Author

You'll also need to change https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ I think

I think it's better to change it when this feature promote to GA

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@kannon92
Copy link
Contributor

/hold

let’s address @sftim comments before we merge this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
@kannon92
Copy link
Contributor

@charles-chenzz do you have some time Thursday or Friday to work on this? I think docs are due this week so it’s be nice to get this PR mergable

@charles-chenzz
Copy link
Member Author

@charles-chenzz do you have some time Thursday or Friday to work on this? I think docs are due this week so it’s be nice to get this PR mergable

I got time to work on this PR later today(16:00 in my timezone now, got some time in 20:00-22:00) and Friday. @kannon92

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2023
kannon92
kannon92 reviewed Nov 16, 2023
View reviewed changes
content/en/docs/concepts/workloads/pods/pod-lifecycle.md
@@ -242,19 +242,21 @@ When a Pod's containers are Ready but at least one custom condition is missing o

### Pod network readiness {#pod-has-network}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim wdyt about changing the name of this section? This was the name of the old condition and we renamed it to PodReadyToStartContainers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about “Pod sandbox readiness”, then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make that change after this PR lands.

@kannon92
Copy link
Contributor

Looking much better @charles-chenzz! Just one nit and then it LGTM.

@harshitasao
Copy link
Contributor

Hi, @charles-chenzz ! Kubernetes v1.29 Docs shadow here. Just a reminder that the deadline to have this PR reviewed and merged is Tuesday, 28 November. Let me know if you need any help!

CCing KEP owners: @kannon92

@katcosgrove
Copy link
Contributor

Hi, @charles-chenzz! The deadline to have this PR merged is tomorrow. What can I do to help get this across the line as soon as possible?

@sftim Do you feel that the changes you requested here have been addressed?

@sftim
Copy link
Contributor

sftim commented Nov 27, 2023

/hold cancel

(when adding a hold, it's a good idea to make it clear what conditions need to be met in order to unhold)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2023
@sftim sftim dismissed their stale review November 27, 2023 15:01

Addressed

sftim
sftim reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41d8a8b8140f3916f9c2da8d180ef8d477ab80d3

@k8s-ci-robot k8s-ci-robot merged commit 4a17ee3 into kubernetes:dev-1.29 Nov 27, 2023
6 checks passed
SIG Node PR Triage automation moved this from WIP to Done Nov 27, 2023
@charles-chenzz charles-chenzz deleted the dev-1.29 branch November 27, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@sftim sftim sftim left review comments

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@charles-chenzz @sftim @harshitasao @kannon92 @tengqm @k8s-ci-robot @katcosgrove