New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ru] Localization of concepts/workloads/_index.md #43785
Conversation
|
Welcome @yungserge! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yungserge! Amazing to see your first PR — thank you very much for your work! I have a few minor suggestions now and will be able to make a thorough review later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 00ae233958e34fa040bdb208542f3f12440bd154
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yungserge 👋
Finally, I thoroughly reviewed the whole text. I hope these corrections will help make the text easier to read & understand 😅 I'm open to discussing any of these suggestions.
P.S. You will also need to squash all your commits when all edits are finalized — we normally do it before merging a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dmitry @shurup, thank you for reviewing, all are good suggestions, I'l take them into account when localizing the next doc. Committed all the changes and going to squash the commits.
Co-Authored-By: Dmitry Shurupov <dmitry.shurupov@palark.com>
Excellent, thank you! I'm approving it, too — since your version was LGTMed by Arhell already, and we didn't change the essence of it. Congratulations on your first localised page going live! /lgtm |
LGTM label has been added. Git tree hash: 2eb9165339bed8ccfc0fc450a331525cb387aa6d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shurup The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This contributes to issue #37044
Ran the page locally with Hugo and everything seems fine to me.
/language ru