Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ru] Localization of concepts/workloads/_index.md #43785

Merged
merged 1 commit into from Nov 18, 2023
Merged

[ru] Localization of concepts/workloads/_index.md #43785

merged 1 commit into from Nov 18, 2023

Conversation

yungserge
Copy link
Contributor

This contributes to issue #37044
Ran the page locally with Hugo and everything seems fine to me.

/language ru

@k8s-ci-robot k8s-ci-robot added the language/ru Issues or PRs related to Russian language label Nov 2, 2023
Copy link

linux-foundation-easycla bot commented Nov 2, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yungserge / name: sergey gabrichidze (aaff964)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @yungserge!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 2, 2023
Copy link

netlify bot commented Nov 2, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit aaff964
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/655771eaf7ecbb0008a0a82c
😎 Deploy Preview https://deploy-preview-43785--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 2, 2023
Copy link
Member

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yungserge! Amazing to see your first PR — thank you very much for your work! I have a few minor suggestions now and will be able to make a thorough review later.

content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00ae233958e34fa040bdb208542f3f12440bd154

Copy link
Member

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yungserge 👋
Finally, I thoroughly reviewed the whole text. I hope these corrections will help make the text easier to read & understand 😅 I'm open to discussing any of these suggestions.

P.S. You will also need to squash all your commits when all edits are finalized — we normally do it before merging a PR.

content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/workloads/_index.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
Copy link
Contributor Author

@yungserge yungserge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dmitry @shurup, thank you for reviewing, all are good suggestions, I'l take them into account when localizing the next doc. Committed all the changes and going to squash the commits.

Co-Authored-By: Dmitry Shurupov <dmitry.shurupov@palark.com>
@shurup
Copy link
Member

shurup commented Nov 18, 2023

Excellent, thank you! I'm approving it, too — since your version was LGTMed by Arhell already, and we didn't change the essence of it.

Congratulations on your first localised page going live!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2eb9165339bed8ccfc0fc450a331525cb387aa6d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shurup

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 64720a1 into kubernetes:main Nov 18, 2023
6 checks passed
@yungserge yungserge deleted the ru-localization branch November 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants