Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blog post for in-tree cloud provider removal going beta #44010

Merged

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Nov 20, 2023

This PR is a placeholder for adds a blog article on the recent status change for KEP-2395 from alpha to beta.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 20, 2023
@elmiko
Copy link
Contributor Author

elmiko commented Nov 20, 2023

cc @krol3 @Priyankasaggu11929 @sftim

@elmiko elmiko changed the title WIP: add blog post for in-tree cloud providers going beta WIP: add blog post for in-tree cloud provider removal going beta Nov 20, 2023
Copy link

netlify bot commented Nov 20, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit eeba8cc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6574c8b66eb95f000807aa0a
😎 Deploy Preview https://deploy-preview-44010--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 21, 2023

This blog article is late (deadline for a placeholder was in October; deadline a reviewable PR was Friday).

Please act to have it ready for review as soon as possible @elmiko.

@krol3
Copy link
Contributor

krol3 commented Nov 22, 2023

Hi @elmiko , here Communication Team 1.29, the deadline to the feature blog be ready to review was this Friday, Nov 17th, the proposal publish date will be Dec 20th. cc: @a-mccarthy @kcmartin @James-Quigley

@elmiko
Copy link
Contributor Author

elmiko commented Nov 22, 2023

i left a comment in slack, but will post here as well.

we discussed the blog post in our sig meeting today, and while we know we are late and will push to get this created as soon as possible, there was concern raised that this blog will describe a breaking change in kubernetes and if we could get it done sooner would it be possible to have it published sooner?

cc @andrewsykim

@sftim
Copy link
Contributor

sftim commented Nov 23, 2023

This is a post release article. There is a different article ahead of release that we use to announce upcoming breaking changes - see https://kubernetes.io/blog/2023/11/16/kubernetes-1-29-upcoming-changes/#removal-of-in-tree-integrations-with-cloud-providers-kep-2395-https-kep-k8s-io-2395 as we have already published that one.

You might want to ask that this removal be highlighted in the release announcement? If that's what you want, you don't need a separate article and this PR could close. Instead, visit #43939 and provide feedback there to request making the cloud provider changes really prominent.

@andrewsykim
Copy link
Member

There is a different article ahead of release that we use to announce upcoming breaking changes - see https://kubernetes.io/blog/2023/11/16/kubernetes-1-29-upcoming-changes/#removal-of-in-tree-integrations-with-cloud-providers-kep-2395-https-kep-k8s-io-2395 as we have already published that one.

I wasn't aware of this section of the release blog. Given it's first on the list of deprecations/removals section I think it's fine?

@sftim
Copy link
Contributor

sftim commented Nov 25, 2023

I wasn't aware of this section of the release blog. Given it's first on the list of deprecations/removals section I think it's fine?

Hi, you might mean:

  • it's fine to have a blog article that repeats what the release blog already explains
  • given that the release blog is putting the removal as a highlighted item, it's fine to not have a blog article to make the same point a day or so later

Could you clarify which point you wanted to make @andrewsykim?


If you do want the repetition, release comms own the decision about whether that makes sense. As I explained, my personal view is that it doesn't: making the same point twice burns a small amount of goodwill across a large number of blog subscribers.

@elmiko elmiko force-pushed the blog-post-for-kep-2395-beta-status branch from a52041d to 18086fa Compare November 28, 2023 16:53
@elmiko elmiko changed the title WIP: add blog post for in-tree cloud provider removal going beta add blog post for in-tree cloud provider removal going beta Nov 28, 2023
@elmiko elmiko marked this pull request as ready for review November 28, 2023 16:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2023
@elmiko
Copy link
Contributor Author

elmiko commented Nov 28, 2023

blog post updated and ready for review

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This announcement is late @elmiko, so please prioritize work on addressing feedback.

Here's a rushed, partial review. For myself, I may or may not have time to help get this to the quality level we like to achieve. The more help you can provide, the better for the project.

It will be a shame to make this big change without communicating it effectively.

@@ -0,0 +1,101 @@
---
layout: blog
title: "Removing In-Tree Cloud Providers Graduates to Beta Status"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Removing In-Tree Cloud Providers Graduates to Beta Status"
title: "Kubernetes 1.29: Cloud Provider Integrations Are Now Separate Components"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update incoming

Comment on lines 28 to 34
## What do you need to do?

If you are upgrading from Kubernetes 1.28+ and are not on Azure, GCE, or vSphere then you are in luck, there are no changes you will need to make. If you **are** on Azure, GCE, or vSphere, or you are upgrading from a version older than 1.28, then read on.

Historically, Kubernetes has included code for a set of cloud providers that included AWS, Azure, GCE, OpenStack, and vSphere. Since the inception of [KEP-2395][kep2395] the community has been moving towards removal of that cloud provider code. The OpenStack provider code was removed in version 1.26, and the AWS provider code was removed in version 1.27. This means that users who are upgradging from one of the affected cloud providers and versions will need to modify their deployments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: this should appear before any mention of the term “SIG”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you saying this paragraph should be moved to the intro section at the top?

Comment on lines 80 to 194
## Want to learn more?

Cloud providers and cloud controller managers serve a core function in Kubernetes. Cloud providers are often the substrate upon which Kubernetes is operated, and the cloud controller managers supply the essential lifeline between Kubernetes clusters and their physical infrastructure.

This post exposes one aspect of how the Kubernetes community interacts with the world of cloud infrastructure providers. If you are curious about this topic and want to learn more the Cloud Provider Special Interest Group (SIG) is the place to go. SIG Cloud Provider hosts bi-weekly meetings to discuss all manner of topics related to cloud providers and cloud controller managers in Kubernetes.

### SIG Cloud Provider

* Regular SIG Meeting: [Wednesdays at 9:00 PT (Pacific Time)](https://zoom.us/j/508079177?pwd=ZmEvMksxdTFTc0N1eXFLRm91QUlyUT09) (biweekly). [Convert to your timezone](http://www.thetimezoneconverter.com/?t=9:00&tz=PT%20%28Pacific%20Time%29).
* [Kubernetes slack][kslack] channel `#sig-cloud-provider`
* [SIG Community page][sig]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this might feel like a feature, readers will experience this more as a loss: they didn't have to do a thing, and now they do. I would omit these details given we're basically imposing work on end users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be clear, remove the SIG details or the entire section on "Want to learn more" ?

@sftim
Copy link
Contributor

sftim commented Nov 28, 2023

The key feedback item: #44010 (comment)

(but please then read all the other feedback)

@sftim
Copy link
Contributor

sftim commented Nov 28, 2023

Hi @elmiko . I've unresolved https://github.com/kubernetes/website/pull/44010/files#r1408096483

I'll go through the other feedback in a bit to check if anything else needs unresolving, but for now: if dismissing feedback without addressing it, please provide a comment about why you've done that. I believe that commenting before dismissing will cut down the overall effort on both sides.

@elmiko elmiko force-pushed the blog-post-for-kep-2395-beta-status branch from e38951f to 41e6ca2 Compare December 6, 2023 14:46
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Optional further tweaks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5525305d1ce9d73ba367a088a49c9170bda466fd

@elmiko elmiko force-pushed the blog-post-for-kep-2395-beta-status branch from 41e6ca2 to f177d5b Compare December 6, 2023 15:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@elmiko
Copy link
Contributor Author

elmiko commented Dec 6, 2023

i took the option! 😂

@sftim
Copy link
Contributor

sftim commented Dec 6, 2023

/lgtm
/approve

🛑 Do not merge until Kubernetes v1.29 is released 🛑

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e01ee0512cf8f3f5a62f67c811afc834b1972c02

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elmiko elmiko force-pushed the blog-post-for-kep-2395-beta-status branch from f177d5b to 1abed16 Compare December 6, 2023 17:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@elmiko
Copy link
Contributor Author

elmiko commented Dec 6, 2023

updated with Andrew's suggestion

@elmiko elmiko force-pushed the blog-post-for-kep-2395-beta-status branch from 1abed16 to bfd5750 Compare December 8, 2023 16:59
@sftim
Copy link
Contributor

sftim commented Dec 9, 2023

I'm going to commit the suggestion from #44010 (comment) @elmiko - hope that's OK by you.

@sftim sftim force-pushed the blog-post-for-kep-2395-beta-status branch from 7803cdb to eeba8cc Compare December 9, 2023 20:06
@sftim
Copy link
Contributor

sftim commented Dec 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a407efb24b5f1220f2b9539bbdccb8bba953cc55

@reylejano
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit dab6bae into kubernetes:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

None yet

9 participants