Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add host paths to psp (#3971)" #4420

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

php-coder
Copy link
Contributor

@php-coder php-coder commented Jul 20, 2017

This reverts the changes from #3971 because support of allowedHostPaths field was also reverted from the Kubernetes (see kubernetes/kubernetes#47851).

PTAL @pweil- @liggitt
CC @simo5
@jhorwit2 @xilabao JFYI


This change is Reviewable

This reverts commit 952e5b4 because
support of this field was also reverted.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
Copy link
Contributor

@pweil- pweil- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @php-coder

@php-coder
Copy link
Contributor Author

@chenopis It's ready to be merged.

@chenopis chenopis self-assigned this Jul 27, 2017
@chenopis chenopis merged commit 15d9cfb into kubernetes:master Jul 27, 2017
@php-coder php-coder deleted the revert_allowed_host_paths branch July 28, 2017 09:20
@php-coder
Copy link
Contributor Author

Now when kubernetes/kubernetes#50212 was merged, this PR can be reverted.

@chenopis
Copy link
Contributor

chenopis commented Sep 1, 2017

@php-coder So, time to revert this PR then?

@liggitt
Copy link
Member

liggitt commented Sep 1, 2017

Not until 1.8 releases

@chenopis
Copy link
Contributor

chenopis commented Sep 1, 2017

Yeah, but can't you revert this in the release-1.8 branch?

@php-coder
Copy link
Contributor Author

BTW let me know if you need my help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants