Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate docs/tasks/administer-cluster/configure-upgrade-etcd.md into Japanese #44374

Merged
merged 47 commits into from
Mar 27, 2024

Conversation

Okabe-Junya
Copy link
Member

@Okabe-Junya Okabe-Junya commented Dec 15, 2023

close #41861

Change List

  • translate docs/tasks/administer-cluster/configure-upgrade-etcd.md into Japanese

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2023
@Okabe-Junya
Copy link
Member Author

/lang ja

@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 15, 2023
Copy link

netlify bot commented Dec 15, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 86d3d05
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65fb8f49dd46280008fb8bce
😎 Deploy Preview https://deploy-preview-44374--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member Author

@Okabe-Junya Okabe-Junya marked this pull request as ready for review December 27, 2023 18:41
@Okabe-Junya Okabe-Junya changed the title [WIP] Translate docs/tasks/administer-cluster/configure-upgrade-etcd.md into Japanese Translate docs/tasks/administer-cluster/configure-upgrade-etcd.md into Japanese Dec 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2023
@Okabe-Junya
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 17, 2024
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

途中までのレビューです。
文の途中で改行されているところが多いため、そこは全体的に見直していただけるとありがたいです。

Okabe-Junya and others added 4 commits February 19, 2024 01:58
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@Okabe-Junya
Copy link
Member Author

Okabe-Junya commented Feb 18, 2024

@t-inu

改めてご丁寧なレビューをありがとうございます。全て確認、修正させて頂きました。(各コメントに適宜返信させていただきました)

再度ご確認いただけると幸いです。よろしくお願いします

@Okabe-Junya
Copy link
Member Author

/cc @t-inu
/assign @nasa9084

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみませんが、確認が遅くなってしまったことで原文が更新されていたため、差分を吸収できるようにコメントをしました。
https://github.com/kubernetes/website/pull/45307/files

Okabe-Junya and others added 10 commits March 21, 2024 10:20
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@Okabe-Junya
Copy link
Member Author

度々ありがとうございます & upstreamへの追従のご提案ありがとうございます。全て確認、commitさせて頂きました。再度ご確認お願い致します

/cc t-inu

@k8s-ci-robot k8s-ci-robot requested a review from t-inu March 21, 2024 01:38
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: abb0561c4045e3ad61631ee101b1a7defce9dcd2

@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2a1046e into kubernetes:main Mar 27, 2024
6 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-41861 branch March 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Add page translation for Operating Etcd Clusters for Kubernetes
4 participants