Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm-reset.md: add instruction about graceful shutdown #45146

Merged
merged 1 commit into from
Feb 19, 2024
Merged

kubeadm-reset.md: add instruction about graceful shutdown #45146

merged 1 commit into from
Feb 19, 2024

Conversation

invidian
Copy link
Member

@invidian invidian commented Feb 15, 2024 •
edited

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 15, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f7291f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65d364b6a76af6000898be71
😎 Deploy Preview https://deploy-preview-45146--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

neolit123
neolit123 reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of nits, but this addition seems OK to me.
thanks

/sig cluster-lifecycle

content/en/docs/reference/setup-tools/kubeadm/kubeadm-reset.md Outdated Show resolved Hide resolved
content/en/docs/reference/setup-tools/kubeadm/kubeadm-reset.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 15, 2024
@sftim
Copy link
Contributor

sftim commented Feb 15, 2024

/sig cluster-lifecycle

@neolit123
Copy link
Member

To address kubernetes/kubeadm#2978.

it can be changed to:

fixes kubernetes/kubeadm#2978

to close the k/kubeadm ticket.

neolit123
neolit123 reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM minus one nit.
please keep the commits squashed to one.

content/en/docs/reference/setup-tools/kubeadm/kubeadm-reset.md Outdated Show resolved Hide resolved
neolit123
neolit123 reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8acd1ec5952f3a2addc47f61a2a6766b7416eb2f

@invidian @neolit123 @sftim
kubeadm-reset.md: add instruction about graceful shutdown
1f7291f 
To address kubernetes/kubeadm#2978.

Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@neolit123
Copy link
Member

please change this in the OP
from To address https://github.com/kubernetes/kubeadm/issues/2978.
to fixes https://github.com/kubernetes/kubeadm/issues/2978

neolit123
neolit123 reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5dee0dade277ad06b57b6e40747f94c8c9921bbb

sftim
sftim reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit e1c7d9e into kubernetes:main Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@invidian @sftim @neolit123 @k8s-ci-robot