Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the feature gate LegacyServiceAccountTokenCleanUp to stable stage #45253

Merged
merged 1 commit into from Mar 12, 2024
Merged

Revise the feature gate LegacyServiceAccountTokenCleanUp to stable stage #45253

merged 1 commit into from Mar 12, 2024

Conversation

yt2985
Copy link
Contributor

@yt2985 yt2985 commented Feb 21, 2024 •
edited

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9c04fe6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65e69c2053463d000810f87f

@yt2985 yt2985 mentioned this pull request Feb 21, 2024
Closed
39 tasks
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2024
@tengqm
Copy link
Contributor

tengqm commented Feb 24, 2024

Where is the upstream code change?

@sftim
Copy link
Contributor

sftim commented Feb 25, 2024

Where is the upstream code change?

I think it's kubernetes/kubernetes#122635

@tengqm
Copy link
Contributor

tengqm commented Feb 26, 2024

@sftim thanks for the pointer.
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@sftim
Copy link
Contributor

sftim commented Feb 28, 2024

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 28, 2024
sftim
sftim reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Please also revise the text for kubernetes.io/legacy-token-invalid-since; see https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-legacy-token-invalid-since

@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2024
@yt2985 yt2985 reopened this Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yt2985
Copy link
Contributor Author

yt2985 commented Mar 5, 2024

Fixed the syncing error. The PR is good to be reviewed now:)

@Okabe-Junya
Copy link
Member

/remove-language de es fr hi id ja ko pt ru vi zh
/remove-area blog
/remove-sig auth

@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language area/blog Issues or PRs related to the Kubernetes Blog subproject sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Mar 10, 2024
@Okabe-Junya
Copy link
Member

Sorry for my missed operation (I missed #45253 (comment))

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 10, 2024
@aramase
Copy link
Member

aramase commented Mar 11, 2024

/assign liggitt

Assigned as part of SIG Auth triage meeting (03/11/2024) for review.

@liggitt
Copy link
Member

liggitt commented Mar 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f2baa9c8df29e72cbbc73e696b054265ac2ce802

@k8s-ci-robot k8s-ci-robot merged commit a872b99 into kubernetes:dev-1.30 Mar 12, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@yt2985 @tengqm @sftim @reylejano @k8s-ci-robot @Okabe-Junya @aramase @liggitt @drewhagen