Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark NewVolumeManagerReconstruction as GA #45282

Merged
merged 2 commits into from Mar 14, 2024
Merged

Mark NewVolumeManagerReconstruction as GA #45282

merged 2 commits into from Mar 14, 2024

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Feb 22, 2024 •
edited

NewVolumeManagerReconstruction is now GA / stable. It should be invisible to users, it only allowed cluster admin to revert back to original behavior if our refactoring was buggy.

WIP:
* implementation must be merged first.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2024
@jsafrane jsafrane mentioned this pull request Feb 22, 2024
Open
8 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 4f6cc59
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65f32780b3c03d000849575f

@dipesh-rawat
Copy link
Member

/sig storage node

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 22, 2024
sftim
sftim reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback

...cs/reference/command-line-tools-reference/feature-gates/new-volume-manager-reconstruction.md Outdated
toVersion: "1.29"
- stage: stable
defaultValue: true
fromVersion: "1.30"
---
Enables improved discovery of mounted volumes during kubelet
startup. Since this code has been significantly refactored, we allow to opt-out in case kubelet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GA docs quality, we like to follow the docs style guide more closely.

Please avoid using “we” here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased the text + updated Kubernetes versions where the feature was alpha / beta. It should be final version for review, I'm removing WIP:.

@bart0sh bart0sh added this to WIP in SIG Node PR Triage Feb 27, 2024
@jsafrane jsafrane changed the title WIP: Mark NewVolumeManagerReconstruction as GA Mark NewVolumeManagerReconstruction as GA Mar 4, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024
@Princesso
Copy link
Contributor

Hello @jsafrane 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

sftim
sftim reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I recommend rewording the text a bit (see inline feedback)

...cs/reference/command-line-tools-reference/feature-gates/new-volume-manager-reconstruction.md Outdated Show resolved Hide resolved
@jsafrane @sftim
Update content/en/docs/reference/command-line-tools-reference/feature…
4f6cc59 
…-gates/new-volume-manager-reconstruction.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>
@jsafrane
Copy link
Member Author

Suggestion accepted

sftim
sftim reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3282f94ab3aab4b744f2779e119b63d5d7821313

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1f2b53a into kubernetes:dev-1.30 Mar 14, 2024
6 checks passed
SIG Node PR Triage automation moved this from WIP to Done Mar 14, 2024
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
1.30 Enhancements Tracking
Archived in project
SIG Node PR Triage
Done
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @dipesh-rawat @Princesso @k8s-ci-robot @drewhagen @sftim