KEP-3836 documentation for 1.30

[alexanderConstantinescu]

Enhancement: kubernetes/enhancements#3836

Original implementation PR: kubernetes/kubernetes#116470

[netlify]

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	c94d2eb
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6602b3ead66a0a0008d9d093
😎 Deploy Preview	https://deploy-preview-45290--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[chanieljdan]

Hi @alexanderConstantinescu 👋 just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST.

Thank you!

[alexanderConstantinescu]

OK, I've added a section under https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer which details the readiness / liveness logic around Kube-proxy and terminating/deleting nodes. From the enhancement we had agreed that we wanted to cover pitfalls w.r.t configuring health check for services of type: LoadBalancer and provide recommendations.

I am not fully sure about the wording to use when providing recommendations to service proxy's / cloud providers, but we can refine this later on. I wanted to get this up today for the "ready for review" deadline

/cc @thockin

[drewhagen]

/sig network
/milestone 1.30

Hello @alexanderConstantinescu 👋, thanks for getting this up for review! A friendly reminder of timeline, this PR needs doc review complete by Doc Freeze on March 26th 18:00 PT to get this into the release.

@thockin @danwinship @aojea
When one of y'all have a moment, please give a review for technical accuracy.

@chanieljdan Please give this a review also - I think your perspective in this domain would be valuable.
Here is a document on the KEP, including the kep.yaml which has information we'll want to spot-check before release. You can also check a preview of the documentation with Netlify above.

I appreciate everyone's help and so will our users! Thank you greatly.

[sftim]

Thanks.

I wonder whether all of this content would find a better home within
https://kubernetes.io/docs/reference/networking/; the Service concept page can have a two sentence summary and a link to the specifics.

How about doing that?

---

Also, it's kube-proxy (no capital K); this matches the container images we build.

[sftim]

Does https://kubernetes.io/docs/reference/networking/ports-and-protocols/ need an update for the changes in this KEP?

[chanieljdan]

Hi @alexanderConstantinescu 👋 I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.

@thockin @danwinship @aojea
Could we get a review for technical accuracy. Thanks!

[sftim]

Any thoughts specifically on #45290 (comment)?

[alexanderConstantinescu]

Any thoughts specifically on #45290 (comment)?

No objection from me, I added an additional commit which addresses that: approvers can decide on if we should keep or not

[sftim]

I wonder if this mostly belongs under the heading ### Traffic to terminating endpoints. (my guess is: yes it does; you could leave in a one sentence hyperlink to the moved text)

and somewhere you ought to add:

{{< feature-state feature_gate_name="KubeProxyDrainingTerminatingNodes" >}}

[alexanderConstantinescu]

I wonder if this mostly belongs under the heading ### Traffic to terminating endpoints

Not quite, what I've added deals with "traffic to terminating nodes"

and somewhere you ought to add:

What does that do? The feature is beta in 1.30 so enabled by default.

[sftim]

The feature state shortcode tells people they need a particular Kubernetes version to use it - see https://kubernetes.io/docs/contribute/new-content/new-features/#ready-for-review-feature-gates

[thockin]

LGTM on tech review

[thockin]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 17d0b83e23b65769bb072dec4c77283beb0fb3b6

[drewhagen]

Looks like we're just missing approve label on this one. Would prefer to get that before Doc Freeze tomorrow March 26th at 18:00 PDT, to evade the need to file an exception. (new process this release)

@kubernetes/sig-docs-en-owners Are there any outstanding concerns or is this ready to approve?

[dipesh-rawat]

@alexanderConstantinescu Perhaps we should consider setting the dev-1.30 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting beta in 1.30.

Also, the PR is currently lacking the doc change to transition the feature gate KubeProxyDrainingTerminatingNodes from Alpha to Beta. The necessary change should be made in the feature gate description file - kube-proxy-draining-terminating-nodes.md (here).

Please refer to the documentation here for further information.

[alexanderConstantinescu]

@alexanderConstantinescu Perhaps we should consider setting the dev-1.30 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting beta in 1.30.

Sure, I will open an additional PR and target dev-1.30 then, you can decide on which PR to merge.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[alexanderConstantinescu]

Opened #45678 - feel free to close this one if needed.

[dipesh-rawat]

Opened #45678 - feel free to close this one if needed.

@alexanderConstantinescu If you could kindly update the Enhancements Issue kubernetes/enhancements#3836 with the merged PR number targeting dev-1.30- PR #45678. Ensuring that the release team is properly informed and tracking the correct pull request would be immensely helpful. Thanks!

[dipesh-rawat]

Closing this PR as these changes having been merged in dev-1.30 as part of another PR #45678

/close

[k8s-ci-robot]

@dipesh-rawat: Closed this PR.

In response to this:

Closing this PR as these changes having been merged in dev-1.30 as part of another PR #45678

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[drewhagen]

/milestone 1.30