Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install-kubectl-windows.md #45469

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Update install-kubectl-windows.md #45469

merged 2 commits into from
Mar 11, 2024

Conversation

Kheiden
Copy link
Contributor

@Kheiden Kheiden commented Mar 7, 2024

Minor documentation update to address:
#45468

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Kheiden / name: Kurt Heiden (6d3a106)
  • ✅ login: sftim / name: Tim Bannister (52db115)

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Kheiden!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2024
@dipesh-rawat
Copy link
Member

@Kheiden Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

dipesh-rawat
dipesh-rawat reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 7, 2024
@Kheiden Kheiden mentioned this pull request Mar 7, 2024
Closed
Arhell
Arhell reviewed Mar 9, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-push commot for restart netlify

rudrakshkarpe
rudrakshkarpe reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@rudrakshkarpe rudrakshkarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this change looks good!

sftim
sftim reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

/lgtm
/merge

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8cb733e3ef492f6a048a209264e5d2da2b11f6e7

@sftim
Copy link
Contributor

sftim commented Mar 9, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2024
@ydFu
Copy link
Member

ydFu commented Mar 10, 2024

/lgtm
Thanks

@T-Lakshmi
Copy link
Contributor

/retest

@T-Lakshmi
Copy link
Contributor

Hi @Kheiden,
Could you try to trigger the PR build again by pushing empty commit to restart netlify.
run below command:
git commit --amend --no-edit && git push --force-with-lease

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 52db115
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65eee5694cd60b00088ccfa8
😎 Deploy Preview https://deploy-preview-45469--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot merged commit 4d804f9 into kubernetes:main Mar 11, 2024
6 checks passed
@Kheiden Kheiden deleted the patch-1 branch March 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@sftim sftim sftim left review comments

@Arhell Arhell Arhell left review comments

@rudrakshkarpe rudrakshkarpe rudrakshkarpe left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@sftim sftim

@ydFu ydFu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Kheiden @k8s-ci-robot @dipesh-rawat @sftim @ydFu @T-Lakshmi @Arhell @rudrakshkarpe