Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: DIY: Create Your Own Cloud with Kubernetes (Part 3) blog post #45498

Merged
merged 7 commits into from Apr 4, 2024
Merged

blog: DIY: Create Your Own Cloud with Kubernetes (Part 3) blog post #45498

merged 7 commits into from Apr 4, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Mar 11, 2024 •
edited

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a85e20
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/660ed8f1cad4150008654613
😎 Deploy Preview https://deploy-preview-45498--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Mar 11, 2024
Merged
Merged
@kvaps kvaps force-pushed the cozystack4 branch 4 times, most recently from 3f02b1c to 57e22ed Compare March 11, 2024 10:52
@kvaps kvaps marked this pull request as ready for review March 11, 2024 10:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@kvaps
Copy link
Member Author

kvaps commented Mar 11, 2024

/assign @mrbobbytables

Gauravpadam
Gauravpadam reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Here's some feedback

content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-03-11-diy-create-your-own-cloud-with-kubernetes-part-3/index.md Outdated Show resolved Hide resolved
@kvaps kvaps force-pushed the cozystack4 branch 5 times, most recently from 2258b00 to 0c608cb Compare March 11, 2024 18:45
@kvaps kvaps requested a review from Gauravpadam March 11, 2024 18:46
@sftim
Copy link
Contributor

sftim commented Mar 14, 2024

/hold

pending assignment of publication date

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
@kvaps kvaps requested a review from sftim March 26, 2024 14:05
@Gauravpadam
Copy link
Member

Gauravpadam commented Mar 28, 2024 •
edited

/lgtm
@kvaps let's aim for publication, 05-04-2024
You can change the dates on the whole set of prs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bbab8380293d4a4c6cbcde859a283ae482e3e9c

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@kvaps
Copy link
Member Author

kvaps commented Mar 29, 2024

@Gauravpadam thank you, I just assigned date 05-04-2024 for all three publications and fixed crosslinks between them

@Gauravpadam
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 503393e4f5ea862a03a198914e40fe9f77210f2a

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@kvaps
Assign time to the publication
e636d5b 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps
Apply suggestions from code review
3a85e20 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps requested a review from sftim April 4, 2024 16:45
@sftim
Copy link
Contributor

sftim commented Apr 4, 2024

Dates look good

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
@sftim
Copy link
Contributor

sftim commented Apr 4, 2024

🆒

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0a869de17671e7dffca49ef23923c593ea31413

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@sftim sftim mentioned this pull request Apr 4, 2024
Closed
@k8s-ci-robot k8s-ci-robot merged commit 1d8cfb0 into kubernetes:main Apr 4, 2024
6 checks passed
@kvaps kvaps mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@sftim sftim Awaiting requested review from sftim

Assignees

@mrbobbytables mrbobbytables

@Gauravpadam Gauravpadam

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kvaps @sftim @Gauravpadam @k8s-ci-robot @mrbobbytables