Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update button label to 'See available versions' in docs homepage #45571

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Update button label to 'See available versions' in docs homepage #45571

merged 2 commits into from
Apr 12, 2024

Conversation

steve-hardman
Copy link
Contributor

@steve-hardman steve-hardman commented Mar 16, 2024 •
edited
Loading

Changed link of "About the documentation" to button with text "See available versions" on homepage

This will fix #43249

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 16, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 16, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0a96654
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65f7a178c96b25000897551d
😎 Deploy Preview https://deploy-preview-45571--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Mar 16, 2024
@dipesh-rawat
Copy link
Member

/retitle Update button label to 'See available versions' in docs homepage

@k8s-ci-robot k8s-ci-robot changed the title Change button Update button label to 'See available versions' in docs homepage Mar 16, 2024
@dipesh-rawat
Copy link
Member

@steve-hardman If this pull request aims to address an existing issue, it would be beneficial to include this information in the PR description. This addition will provide reviewers with context, aiding in their understanding of the changes being proposed.

@steve-hardman steve-hardman mentioned this pull request Mar 18, 2024
Closed
@steve-hardman @dipesh-rawat
Change button
0a96654 
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
@steve-hardman
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 18, 2024
dipesh-rawat
dipesh-rawat reviewed Apr 6, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

Preview Page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 32a2a1c83462fcf1764d2bca8fd1bf98d52c1cd1

@steve-hardman
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

Trying to do bot's suggestion. (sorry if it not right thing to do)

/assign @sftim

@sftim
Copy link
Contributor

sftim commented Apr 12, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 84cb81a into kubernetes:main Apr 12, 2024
6 checks passed
@steve-hardman steve-hardman deleted the fix-button branch April 19, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@windsonsea windsonsea Awaiting requested review from windsonsea

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@dipesh-rawat dipesh-rawat

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button for "About the documentation"
4 participants
@steve-hardman @dipesh-rawat @k8s-ci-robot @sftim