-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt-br] Add docs/tasks/access-application-cluster/ingress-minikube.md #45584
Conversation
Welcome @matheusde! |
@matheusde Thanks you for your contribution. |
/retitle [pt-br] Localize docs/tasks/access-application-cluster/ingress-minikube.md |
content/pt-br/ingress-minikube.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @matheusde, Thank you so much for your contribution! I appreciate your effort in helping with the localization of the website. However, I'd like to mention that the current location (content/pt-br/ingress-minikube.md) of the localized file isn't correct. It should be kept within "/content/pt-br/docs/tasks/access-application-cluster", mirroring the corresponding English file.
/easycla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dipesh-rawat thanks for the review
I made the requested changes
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/easycla
/cc edsoncelio |
/cc |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @stormqueen1990 @dipesh-rawat I commited the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, @matheusde! 👋🏻
Thank you very much for your contribution!
Overall this is looking really good. I found some places that need minor adjustments and left as comments in the PR. If you have any questions or concerns please feel free to reach out in the #kubernetes-docs-pt
channel in Kubernetes Slack.
I also have a request: could you please run
scripts/linkchecker.py -f content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
in your local copy and adjust all the links that the script returns?
Once you're done with the changes, feel free to request a new review from me by writing /cc @stormqueen1990
in a comment in this PR, so I get notified to take another look 😄
Olá @matheusde! 👋🏻
Muito obrigada pela sua contribuição!
De forma geral essa localização está bem encaminhada. Encontrei alguns lugares em que pequenos ajustes são necessários e deixei como comentários nesse PR. Se você tiver quaisquer dúvidas a respeito, não hesite em nos contatar no canal #kubernetes-docs-pt
do Slack do Kubernetes.
Tenho também um pedido: poderia por favor rodar o script
scripts/linkchecker.py -f content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
na sua cópia local e ajustar todos os links que o script indicar?
Quando você finalizar os ajustes, por favor solicite uma nova revisão minha escrevendo /cc @stormqueen1990
em um comentário neste PR para que eu seja notificada para olhar novamente 😄
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
/retitle [pt-br] Add docs/tasks/access-application-cluster/ingress-minikube.md |
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
content/pt-br/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
…nikube.md Co-authored-by: Edson C. <edsoncelio@users.noreply.github.com>
…nikube.md Co-authored-by: Edson C. <edsoncelio@users.noreply.github.com>
…nikube.md Co-authored-by: Edson C. <edsoncelio@users.noreply.github.com>
…nikube.md Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
…nikube.md Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
…nikube.md Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
Hi @stormqueen1990 , thanks for your review |
/cc @stormqueen1990 |
/lgtm |
LGTM label has been added. Git tree hash: e9a2eb26832c4982cec27fff8989de005dcee6e8
|
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stormqueen1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the brazilian portuguese version of docs/tasks/access-application-cluster/ingress-minikube.md