Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blog content files to move author details in front-matter #45957

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update blog content files to move author details in front-matter #45957

wants to merge 2 commits into from
+12 −11

Conversation

dipesh-rawat
Copy link
Member

@dipesh-rawat dipesh-rawat commented Apr 21, 2024 •
edited

This PR extends the changes made in PR #45865 and implements those changes to all the blog files as per the recommendation in #45865 (comment). The primary change involves relocating author details into the metadata within the front matter.

Edit: I'll split this into several PRs each focusing on a single year blog.

  • Changes merged for 2024 blogs
  • Changes merged for 2023 blogs
  • Changes merged for 2022 blogs
  • Changes merged for 2021 blogs
  • Changes merged for 2020 blogs
  • Changes merged for 2019 blogs
  • Changes merged for 2018 blogs

Useful Link

Preview Blog Summary Page

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dipesh-rawat. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Apr 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 21, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f9d9ebf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/665c99dd591a1200087f0cb4
😎 Deploy Preview https://deploy-preview-45957--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gauravpadam
Gauravpadam reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Since this will standardize the format, Thanks @dipesh-rawat

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 20556819bfb983dcb45865434dd5dd1c29f64e0f

sftim
sftim reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this easier to review, I recommend splitting it by the year of the article.

Would you do that @dipesh-rawat?

@ricardoamaro
Copy link
Contributor

I agree with @sftim
Impressive work btw!!

@dipesh-rawat dipesh-rawat force-pushed the add-blog-front-matter-author branch 2 times, most recently from 903c475 to 36ac34a Compare April 22, 2024 19:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@dipesh-rawat
Copy link
Member Author

To make this easier to review, I recommend splitting it by the year of the article.

Sure, I've done that now.

@dipesh-rawat dipesh-rawat requested a review from sftim April 22, 2024 19:07
@dipesh-rawat
Copy link
Member Author

Reviewing over 350+ files will be a substantial task for this PR. To tackle this efficiently, I'll be breaking down the pull request into individual ones (each focusing on a single year), starting from this year’s blogs and progressing in descending order.

This was referenced Apr 23, 2024
Merged
Merged
@dipesh-rawat dipesh-rawat mentioned this pull request Apr 28, 2024
Merged
@dipesh-rawat dipesh-rawat force-pushed the add-blog-front-matter-author branch 2 times, most recently from 9a72642 to 379fa64 Compare May 1, 2024 12:21
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 1, 2024
@dipesh-rawat dipesh-rawat force-pushed the add-blog-front-matter-author branch from 379fa64 to d630747 Compare May 1, 2024 12:21
@dipesh-rawat dipesh-rawat mentioned this pull request May 1, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2024
@dipesh-rawat dipesh-rawat force-pushed the add-blog-front-matter-author branch from d630747 to 7a2793b Compare May 2, 2024 10:48
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request May 2, 2024
Merged
@dipesh-rawat dipesh-rawat force-pushed the add-blog-front-matter-author branch from 7a2793b to c8374f6 Compare May 6, 2024 23:42
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 6, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request May 6, 2024
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request May 13, 2024
Merged
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request Jun 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@sftim sftim Awaiting requested review from sftim

Assignees

@Gauravpadam Gauravpadam

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dipesh-rawat @k8s-ci-robot @ricardoamaro @Gauravpadam @sftim