Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-br] Update docs/setup/production-environment/tools/kubeadm/install-kubeadm.md #46001

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ricardoamaro
Copy link
Contributor

Per #44765 grabbed the https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/ and translated that to pt-br taking into account the already existing page.

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added language/pt Issues or PRs related to Portuguese language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2024
@ricardoamaro ricardoamaro marked this pull request as draft April 24, 2024 12:59
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a35583e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66319ed4c155c00008cc723d
😎 Deploy Preview https://deploy-preview-46001--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edsoncelio
Copy link
Member

/cc

@ricardoamaro ricardoamaro marked this pull request as ready for review April 28, 2024 17:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2024
Copy link
Member

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

A few minor issues to fix.
After that will be LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign femrtnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsoncelio
Copy link
Member

PTAL @stormqueen1990

@stormqueen1990
Copy link
Member

/retitle [pt-br] Update docs/setup/production-environment/tools/kubeadm/install-kubeadm.md

@k8s-ci-robot k8s-ci-robot changed the title Install Kubeadm page in Brazilian Portuguese is outdated [pt-br] Update docs/setup/production-environment/tools/kubeadm/install-kubeadm.md Apr 30, 2024
@ricardoamaro
Copy link
Contributor Author

Obrigado pelo feedback @edsoncelio

Copy link
Member

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ricardo,
Just a few more changes before approve :)

Address feedback

Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants