Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] update the term "Node" in /docs/concepts/scheduling-eviction/assign-pod-node.md #46074

Merged
merged 2 commits into from
May 27, 2024
Merged

[ja] update the term "Node" in /docs/concepts/scheduling-eviction/assign-pod-node.md #46074

merged 2 commits into from
May 27, 2024
+72 −72

Conversation

Okabe-Junya
Copy link
Member

Feature Description

  • Fix the term "Node/node" to "ノード" in /docs/concepts/scheduling-eviction/assign-pod-node.md

Ref

https://kubernetes.io/ja/docs/contribute/localization/#terminology

ただし、ノード(Node)に関しては明確にKubernetesとしてのNodeリソース(例: kind: Nodeやkubectl get nodes)を指していないのであれば、「ノード」と表記してください。

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/localization General issues or PRs related to localization labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Apr 29, 2024
@Okabe-Junya
Copy link
Member Author

/label refactor
/assign nasa9084

@k8s-ci-robot k8s-ci-robot added the refactor Indicates a PR with large refactoring changes e.g. removes files or moves content label Apr 29, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 233b718
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6630bf8ce96dc80008d08bff
😎 Deploy Preview https://deploy-preview-46074--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member Author

Deploy preview:

bells17
bells17 reviewed Apr 29, 2024
View reviewed changes
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
* [アフィニティとアンチアフィニティ](#affinity-and-anti-affinity)
* [nodeName](#nodename)フィールド
* [Podのトポロジー分散制約](#pod-topology-spread-constraints)

## Nodeラベル {#built-in-node-labels}
## ノードラベル {#built-in-node-labels}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの項目はNodeリソースに対する言及のように思えるので Node の表現のままで良い気がしました。

https://kubernetes.io/ja/docs/contribute/localization/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あー別に明確ではないから ノード でよいのかな？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントありがとうございます！

あー別に明確ではないから ノード でよいのかな？

こちらの認識の通りですね。NodeAffinity や、nodeName のような明らかな固有名詞以外は "ノード" 表記に置き換えたいと考えていました

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ごめんなさい、ラベルということはNodeリソースに付くラベル情報な気がするのでNodeの方が適当かも、と思いました

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Okabe-Junya ここ直さないですか？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すいません。。コメントしていませんでした。自分の認識では、#46074 (comment) と同じで "ノード" のままで問題ないと考えています

Podをノードに割り当てる もノードラベルに関する言及がされているページですが、"ノード" で統一されているように思いました

@bells17
Copy link
Contributor

bells17 commented Apr 29, 2024

/lgtm

コメントしてしまいましたが、ノードで問題ない気がしましたのでlgtmさせていただきます。
#46074 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e1f7cf67674a0d19111c43c4d35af82dfa7b8fba

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@Okabe-Junya
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 30, 2024
atoato88
atoato88 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私のレビュー結果をコメントしました。

（ただ、正直この手の表記は統一が難しいかもなぁと思いながらレビューしました。
既存のルールがある上で、それでもなお時間が経ったり、他の人が読んだときの感じ方でまた似たような更新PRが出てきそうな予感もしました。ただ、それはこのPRではオフトピックかなと思います。）

content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md Show resolved Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md Show resolved Hide resolved
@atoato88
Copy link
Contributor

/lgtm
さっきのレビューがコメントだけでした。もうしわけありません。
私のレビュー結果としてはいまの状態で良いと思いましたのでLGTMです。

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ee49e44ffbbee32b36337475db852e5d168a874

@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5291229 into kubernetes:main May 27, 2024
6 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-node branch May 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@bells17 bells17 bells17 left review comments

@inductor inductor inductor left review comments

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@atoato88 atoato88

@bells17 bells17

@nasa9084 nasa9084

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Okabe-Junya @bells17 @k8s-ci-robot @atoato88 @nasa9084 @inductor