Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Switch to Kubernetes colors for CRI streaming blog #46086

Closed
wants to merge 1 commit into from
Closed

WIP: Switch to Kubernetes colors for CRI streaming blog #46086

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 30, 2024 •
edited

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Apr 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 30, 2024 07:18
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 30, 2024
@saschagrunert saschagrunert mentioned this pull request Apr 30, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cb47999
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66309d8240cee60008e77b6a
😎 Deploy Preview https://deploy-preview-46086--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saschagrunert
Switch to Kubernetes colors for CRI streaming blog
cb47999 
Follow-up on kubernetes#45821

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@sftim
Copy link
Contributor

sftim commented Apr 30, 2024

Is this still a WIP?

@saschagrunert
Copy link
Member Author

Is this still a WIP?

Yes, I'm not exactly sure how to apply the Kubernetes colors to the sequence diagram.

@saschagrunert
Copy link
Member Author

Not required due to #46123

@saschagrunert saschagrunert deleted the cri-streaming-blog-colors branch May 2, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @k8s-ci-robot @sftim