Improve concepts "Overview" page #46466
Conversation
- Line number: 99 container needs to start. Wouldn't it be easier if this behavior was handled by a system? TO container needs to start. Wouldn't it be easier if this behaviour was handled by a system? - Line number: 160 data-processing frameworks (for example, Spark), databases (for example, MySQL), caches, nor TO data-processing frameworks (for example, Spark), databases (for example, MySQL), caches, or This all changes are verified using word checking tools like grammerly.
The committers listed above are authorized under a signed CLA. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/docs
|
Welcome @Gauravbharane! |
k8s-ci-robot
added
the
size/XS
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @Gauravbharane - thanks for opening the pull request. "Behavior" is a correct spelling in American English. As for the other change, I don't believe that warrants an individual PR. If there are additional fixes that could make this more substantial, feel free to add them and we can review them at that time. |
There was a problem hiding this comment.
@Gauravbharane Thanks for your contribution. Since we try to follow the Trivial Edits guidelines as much as we can, I encourage you to seek out additional things for improvement within the same document (or any other around you went through recently). Submitting a PR with several minor fixes enhances its value and we'll be more likely to merge it. Keep up the great work!
| @@ -96,7 +96,7 @@ Containers have become popular because they provide extra benefits, such as: | |||
| Containers are a good way to bundle and run your applications. In a production | |||
| environment, you need to manage the containers that run the applications and | |||
| ensure that there is no downtime. For example, if a container goes down, another | |||
| container needs to start. Wouldn't it be easier if this behavior was handled by a system? | |||
| container needs to start. Wouldn't it be easier if this behaviour was handled by a system? | |||
There was a problem hiding this comment.
The current spelling of "behavior" is accurate, as it aligns with the style guide that specifies the use of U.S. English spelling and grammar in our English-language documentation. (Reference to the style guide (here))
|
/retitle Improve concepts "Overview" page |
k8s-ci-robot
changed the title
| @@ -157,7 +157,7 @@ Kubernetes: | |||
| Delivery, and Deployment (CI/CD) workflows are determined by organization cultures and | |||
| preferences as well as technical requirements. | |||
| * Does not provide application-level services, such as middleware (for example, message buses), | |||
| data-processing frameworks (for example, Spark), databases (for example, MySQL), caches, nor | |||
| data-processing frameworks (for example, Spark), databases (for example, MySQL), caches, or | |||
There was a problem hiding this comment.
To me, “nor” is idiomatic US English. But I actually speak UK English.
|
Hi @Gauravbharane! As you can see, we've had several helpful reviews from the SIG Docs community on your PR. They've suggested that, at this time, your changes aren't accurate and could be trivial for this page. Are there any other edits or additions you'd like to suggest for this PR? If not, unfortunately, we'll need to close this PR. However, we appreciate your contribution and suggest that you take a look at other pages that could use improvement. Please note, that our Kubernetes documentation uses US English, especially if you continue to use tooling to assist with grammar and spellcheck. |
|
Sure thanks for clearing that! |
|
/close |
|
@natalisucks: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Line number: 99 container needs to start. Wouldn't it be easier if this behavior was handled by a system? TO
container needs to start. Wouldn't it be easier if this behaviour was handled by a system?
Line number: 160 data-processing frameworks (for example, Spark), databases (for example, MySQL), caches, nor TO
data-processing frameworks (for example, Spark), databases (for example, MySQL), caches, or
This all changes are verified using word checking tools like grammerly.