Fixing heading issues with Openstack provider documentaiton. #534
Conversation
| @@ -28,6 +28,7 @@ If you already have the required versions of the OpenStack CLI tools installed a | |||
|
|
|||
| ```sh | |||
| sudo pip install -U --force 'python-openstackclient==2.4.0' | |||
| sudo pip install -U --force 'python-heatclient==1.1.0' | |||
There was a problem hiding this comment.
I understand the fixing of the heading issues by adding whitespace, but did you really mean to add this line here?
There was a problem hiding this comment.
Yes, the openstackclient won't do heat things without the heatclient. I only caught it after doing a cleanroom test.
|
@kelseyhightower Looking good? |
|
@johndmulhausen Looking good? |
|
@elsonrodriguez Are you the maintainer of this doc, or is this a one-off fix? I am looking for the proper reviewer. According to the table in here: This is maintained by @FujitsuEnablingSoftwareTechnologyGmbH, but I can't assign it to that user |
|
@pwittrock I re-wrote this documentation based on work from @zreigz, who is a member of @FujitsuEnablingSoftwareTechnologyGmbH |
|
@zreigz Can you comment on if this PR looks good? |
|
LGTM |
1 similar comment
|
LGTM |
…field "selector" in io.k8s.api.apps.v1.DeploymentSpec' (kubernetes#534) Adding selector solve the issue. Fixes kubernetes#533 Signed-off-by: Mario Vejlupek <mario.vejlupek@embedit.cz>
Added stubs in the Installation page for various common installation methods
No description provided.