adding explanation for product_uuid uniqueness #5885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added steps for how to verify macaddress and product_uuid with reference to the bug in github that identified this need originally (kubernetes/kubeadm#31)
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview ready! Built with commit d768c91 https://deploy-preview-5885--kubernetes-io-master-staging.netlify.com |
|
@heckj Refresh my memory. Has this been tech reviewed, maybe in some other PR? |
|
@steveperry-53 yeah - this is a replacement for my dummy move of "delete the branch" - earlier PR with the same content that was LGTM'd was #5368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added steps for how to verify macaddress and product_uuid with
reference to the bug in github that identified this need originally
(kubernetes/kubeadm#31)
added steps for how to verify macaddress and product_uuid with reference to the bug in github that identified this need originally (kubernetes/kubeadm#31)
Added because I wasn't clear what product_uuid was, or how to check it - so I dug it out. Details where in the original bug (referenced). I wasn't sure if it was a good idea or not to reference the bug that caused this to be added, so I opted to include a link to it, even though it's closed. If that's not good form, I can easily remove it.
This change is