Custom Resource Validation: remove alpha warning, change enable instructions to disable #6066

steveperry-53 · 2017-10-26T20:44:47Z

@colemickens
Duplicates #6065.
Per this issue, we are promoting Custom Resource Validation to beta in 1.9: kubernetes/kubernetes#53829

This change is

disable

k8sio-netlify-preview-bot · 2017-10-26T20:46:37Z

Deploy preview ready!

Built with commit 5355ea0

https://deploy-preview-6066--kubernetes-io-master-staging.netlify.com

steveperry-53 · 2017-10-26T20:48:43Z

@colemickens If this looks OK to you, I'll merge it into the release-1.9 branch.

colemickens · 2017-10-26T20:51:22Z

@steveperry-53, can I just correct the PR I already have open for this? Not sure why you opened a new one?

steveperry-53 · 2017-10-26T20:54:16Z

@colemickens Yes, if you prefer, you can fix #6065 and close #6066.

colemickens · 2017-10-26T20:54:54Z

Aha, I get what happened now (hadn't seen your comment over on 6065 yet). It's fine either way - I rebased my branch if you want to reopen and merge my PR. If you want to merge yours that's fine! Thanks!

One thing though, maybe we should hold off merging until the actual promotion goes into main tree.

steveperry-53 · 2017-10-26T20:56:37Z

@colemickens We can merge this into release-1.9. The content in release-1.9 won't be public until the Kubernetes 1.9 product is released at the end of December (or early January). Does that sound OK?

nikhita · 2017-10-26T23:40:25Z

docs/tasks/access-kubernetes-api/extend-api-custom-resource-definitions.md

@@ -190,12 +190,12 @@ Additionally, the following restrictions are applied to the schema:
 - The field `uniqueItems` cannot be set to true.
 - The field `additionalProperties` cannot be set to false.

-This feature is __alpha__ in v1.8 and may change in backward incompatible ways.
-Enable this feature using the `CustomResourceValidation` feature gate on
+This feature is __beta__ in v1.9.


from v1.9 instead of in v1.9?

Split the difference? "This feature is beta beginning with v1.9" ?

Yup, this sounds better! 👍

nikhita · 2017-10-26T23:43:58Z

The content in release-1.9 won't be public until the Kubernetes 1.9 product is released at the end of December (or early January). Does that sound OK?

@steveperry-53 technically, this makes perfect sense! But it feels "righter" to have the docs merged after the feature has really moved to beta. 😄

The corresponding PR kubernetes/kubernetes#54647 should be merged soon though!

nikhita · 2017-10-26T23:47:36Z

Copying my comment from kubernetes/kubernetes#54647 (comment),

IMO this should be called "CustomResource validation" instead of "CRD Validation" (especially in the release note). We define the schema in the CRD but we are validating the custom resources, not the CRD itself.

This doesn't affect the docs but would be nice to have the PR title reflect the right nomenclature (so that it's easier to search in the future). :)

nikhita · 2017-10-26T23:51:15Z

Also, maybe we should mention the beta statement in the beginning and then explain what the feature is really about. WDYT?

colemickens · 2017-10-27T00:19:01Z

Sure, let me add some more descriptive text! And agree'd on the PR title, will fix in all places.

colemickens · 2017-10-27T00:19:31Z

Except that I can't change the title now because this is no longer my PR. :/

nikhita · 2017-10-27T03:48:32Z

@steveperry-53 Can you make the changes? Thanks!

colemickens · 2017-11-10T23:29:00Z

Hi @steveperry-53. I'm fine with your PR being merged. Thanks! I'm happy to pull and rebase in the future :).

Let's hold off until the CI goes green and this actually gets merged in the main repo though: kubernetes/kubernetes#54647

colemickens · 2017-11-15T23:43:00Z

On second thought, I've got my wires crossed and this PR isn't in yet. Hold off a bit more.

colemickens · 2017-11-16T19:43:57Z

It merged: kubernetes/kubernetes#54647 (comment).

Can you merge this @steveperry-53 ? Thanks!

* Trivial change to open release branch * Undo trivial change * add service ipvs overview * Add instructions on how to setup kubectl * Document conntrack dependency for kube-proxy * Add an a This is kind of jarring / missing an article. I'm guessing it should either be ' to a rack of bare metal servers.' or '...to racks of bare metal servers.'. * adding example responses for common issues - support request - code bug report * Trivial change to open release branch * Undo trivial change * Signed-off-by: Ziqi Zhao <zhaoziqi@qiniu.com> (#5366) Fix the not-working test case yaml for /doc/concepts/storage/volumes.md * kubectl-overview * temp fix for broken pod and deployment links * Update Table of Solutions for Juju * Revise certificates documentation (#5965) * Update review-issues.md Some edits for clarity and condensed language. * Update init-containers.md Fix leading spaces in commands. * Update kubectl-overview.md Fix format. * Update clc.md Fix format. * Update openstack-heat.md The url no need. just highlight. * Typo I believe this should be "users" not "uses" * making explicit hostname uniq requirement * Update scheduling-hugepages.md * Update update-daemon-set.md * fix redirection of PersistentVolume * Update hpa.md * update kubectl instruction * Use the format of kubeadm init * fix spelling error guarnatees to guarantees * add matchLabels description (#6020) * search and replace for k8s.github.io to website (#6019) * fix scale command of object-management (#6011) * Update replicaset.md (#6009) * Update secret.md (#6008) * specify password for mysql image (#5990) * specify password for mysql image * specify password for mysql image * link error for run-stateless-application-deployment.md (#5985) * link error for run-stateless-application-deployment.md * link error for run-stateless-application-deployment.md * Add performance implications of inter-pod affinity/anti-affinity (#5979) * 404 monthly maintenance - October 2017 (#5977) * Updated redirects * More redirects * Add conjure-up to Turnkey Cloud Solutions list (#5973) * Add conjure-up to Turnkey Cloud Solutions list * Changed wording slightly * change the StatefulSet to ReplicaSet in reference (#5968) * Clarification of failureThreshold of probes (#5963) * Mention usage of block storage version param (#5925) Mention usage of block storage version (bs-version) parameter to workaround attachment issues using older K8S versions on an OpenStack cloud with path-based endpoints. Resolves: #5924 * Update sysctl-cluster.md (#5894) Include guide on enabling unsafe sysctls in minikube * Avoid Latin phrases & format note (#5889) * Avoid Latin phrases & format note according the Documentation Style Guide * Update scratch.md * Update scratch.md * resolves jekyll rendering error (#5976) - chinese isn't understood for keys in YAML frontmatter in jekyll, so replaced it with the english equivalent that doesn't throw the following error on rendering: Error reading file src/kubernetes.github.io/cn/docs/concepts/cluster-administration/device-plugins.md: (<unknown>): could not find expected ':' while scanning a simple key at line 4 column 1 * Change VM to pod. (#6022) * Add link to custom metrics. (#6023) * Rephrase core group. (#6024) * Added explanation on context to when joining (#6018) * Update create-cluster-kubeadm.md (#5761) Update Canal version in pod network apply commands * Fixes issue #5620 (#5869) * Fixes issue #5620 Signed-off-by: Brad Topol <btopol@us.ibm.com> * Restructured so that review process is for both current and upcoming releases. Added content describing the use of tech reviewers. * Removed incorrect Kubernetes reviewer link. * Fixed tech reviewer URL to now use website * Update pod-priority-preemption.md fix-wrong-link-to-pod-preemption * pod-security-policy.md: add links to the page about admission plugins. * Adding all files for BlaBlaCar case study (#5857) * Adding all files for BlaBlaCar case study * Update blablacar.html * Fix changed URL for google containers * Add /docs/reference/auto-generated directory * correct the downwardapi redirect * Remove links using "here" * Rename to /docs/reference/generated directory * add Concept template * Change title to just Ingress * Link mistake (#6038) * link mistake * link mistake * skip title check for skip_title_check.txt * skip title check for skip_title_check.txt * remove doesn't exist link. * Fix podpreset task (#5705) * Add a simple pod manifest to pod overview (#5986) * Split PodPreset concept out from task doc (#5984) * Add selector spec description (#5789) * Add selector spec description * Fix selector field explanation * Put orphaned topics in TOC. (#6051) * static-pod example bad format in the final page (#6050) * static-pod example bad format in the final page * static-pod example bad format in the final page * static-pod example bad format in the final page * static-pod example bad format in the final page * static-pod example bad format in the final page * Fix `backoffLimit` field misplacement (#6042) It should be placed in JobSpec according to: https://github.com/kubernetes/kubernetes/blob/master/api/swagger-spec/batch_v1.json#L1488-L1514 * Update addons.md (#6061) * add info about VMware NSX-T CNI plugin (#5987) * add info about VMware NSX-T CNI plugin Hello, I'm VMware Networking and Security Architect and would like to include short information about our CNI plugin implementation similar to what other vendors did Best regards Emil Gagala * Update networking.md * Update networking.md * Update networking.md * Update: Using universal zsh configuration (#5669) * Update install-kubectl.md Zsh is not only oh-my-zsh, so I added universal configuration for zsh that also can be used in prezto. * fix merge error after rebase * Operating etcd cluster for Kubernetes bad format in the final page (#6056) * Operating etcd cluster for Kubernetes bad format in the final page * Update configure-upgrade-etcd.md * Update configure-upgrade-etcd.md * Usage note and warning tags. (#6053) * Usage note and warning tags. * Update configure-upgrade-etcd.md * Update configure-upgrade-etcd.md * Document jekyll includes snippets * Add jekyll includes to docs home toc - Remove extra kubernetes home in toc * document docker cgroupdriver req (#5937) * Update test blacklists (#6063) * Update toc check blacklist * Update title check blacklist * wip * wip * Fix typo * Document unconfined apparmor profile * Revert "Document the unconfined profile for AppArmor" (#6268) * CRD Validation: remove alpha warning, change enable instructions to (#6066) disable * Documented service annotation for AWS ELB SSL policy * kubeadm: add a note about the new `--print-join-command` flag. This is a new flag for the `kubeadm token create` command. * Add a note to PDB page * Improve Kubeadm reference doc (#6103) * automatically-generated kubeadm reference doc * user-mantained kubeadm reference doc * Documentation for CSIPersistentVolume * change replicaset documentation to use apps/v1 APIs * Update service.md ipvs alpha version -> beta version * Updated Deployment concept docs (#6494) * Updated Deployment concept docs * Addressed comments * Documentation for volume scheduling alpha feature * Update admission control docs for webhooks * Improve DNS documentation (#6479) * update ds for 1.9 * Update service.md * Update service.md * Revert "begin updating webhook documentation" (#6575) * Update version numbers to include 1.9 (#6518) * Update site versions for 1.9 * Removed 1.4 docs * Update _config.yml * Update _config.yml * updates for raw block devices * rbac: docs for aggregated cluster roles (#6474) * Added IPv6 information for Kubelet arguments (#6498) * Added IPv6 info to kube-proxy arguments * Added IPv6 information for argument for kubelet * Update PVC resizing documentation (#6487) * Updates for Windows Server version 1709 with K8s v1.8 (#6180) * Updated for WSv1709 and K8s v1.8 * Updated picture and CNI config * Fixed formatting on CNI Config * Updated docs to reference Microsoft/SDN GitHub docs * fix typo * Workaround for Jekyllr frontmatter * Added section on features and limitations, with example yaml files. * Update index.md * Added kubeadm section, few other small fixes * Few minor grammar fixes * Update access-cluster.md with a comment that for IPv6 the user should use [::1] for the localhost * Addressed a number of issues brought up against the base PR * Fixed windows-host-setup link * Rewrite PodSecurityPolicy guide * Update index.md Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> * Spelling correction and sentence capitalization. - Corrected the spelling error for storing, was put in as 'stoing'. - Capitalized list items. - Added '.' at end of sentences in the list items. * Update index.md * Update index.md * Addressed comments and rebased * Fixed formatting * Fixed formatting * Updated header link * Updated hyperlinks * Updated warning * formatting * formatting * formatting * Revert "Update access-cluster.md with a comment that for IPv6" This reverts commit 31e4dbd. * Revert "fix typo" This reverts commit c056787. * Revert "Workaround for Jekyllr frontmatter" This reverts commit b84ac59. * Fixed grammatical issues and reverted non-related commits * Revert "Rewrite PodSecurityPolicy guide" This reverts commit 5d39cfe. * Revert "Spelling correction and sentence capitalization." This reverts commit 47eed43. * Fixed auto-numbering * Minor formatting updates * CoreDNS feature documentation (#6463) * Initial placeholder PR for CoreDNS feature documentation * Remove from admin, add content * Fix missing endcapture * Add to tasks.yml * Review feedback * Postpone Deletion of a Persistent Volume Claim in case It Is Used by a Pod (#6415) * Postpone Deletion of a Persistent Volume Claim in case It Is Used by a Pod A new feature PVC Protection was added into K8s 1.9 that's why this documentation change is needed. * Added tag at the top of each new area. * Fix typo * Fix: switched on in (all kubelets) -> (all K8s components). * Added link to admission controller * Moved PVC Protection configuration into Before you begin section. * Added steps how to verify PVC Protection feature. * Fixes for admission controller plugin description and for PVC Protection description in PVC lifecycle. * Testing official rendering of enumerations (1., 2., 3., etc.) * Re-write to address comments from review. * Fixed definition when a PVC is in active use by a pod. * Change auditing docs page for 1.9 release (#6427) * Change auditing docs page for 1.9 release Signed-off-by: Mik Vyatskov <vmik@google.com> * Address review comments Signed-off-by: Mik Vyatskov <vmik@google.com> * Address review comments Signed-off-by: Mik Vyatskov <vmik@google.com> * Address review comments Signed-off-by: Mik Vyatskov <vmik@google.com> * Fix broken link Signed-off-by: Mik Vyatskov <vmik@google.com> * short circuit deny docs (#6536) * line wrap * short circuit deny * address comments * Add kubeadm 1.9 upgrade docs (#6485) * kubeadm: Improve kubeadm documentation for v1.9 (#6645) * Update admission control docs for webhooks (re-send #6368) (#6650) * Update admission control docs for webhooks * update in response to comments * Revamp rkt and add CRI-O as alternative runtime (#6371) Signed-off-by: Lorenzo Fontana <lo@linux.com> * Documented NLB for Kubernetes 1.9 (#6260) * Added IPV6 information to setup cluster using kubeadm (#6465) * Added IPV6 information to setup cluster using kubeadm * Updated kubeadm.md & create-cluster-kubeadm.md with IPv6 related information * Added IPv6 options for kubeadm --init & automated address binding for kube-proxy based on version of IP configured for API server) * Changes to kubeadm.md as per comments * Modified kubeadm.md and create-cluster-kubeadm.md * Implemented changes requested by zacharysarah * Removed autogenerated kubeadm.md changes * StatefulSet 1.9 updates. (#6550) * updates sts concept and tutorials to use 1.9 apps/v1 * Update statefulset.md * clarify pod name label * Garbage collection updates for 1.9 (#6555) * 1.9 gc policy update * carify deletion * Couple nits for dnsConfig doc (#6652) * Add doc for AllowedFlexVolume (#6563) * Update OpenStack Cloud Provider API support for v1.9 (#6638) * Flex volume is GA. Remove alpha notation. (#6666) * Update generated ref docs for Kubernetes and Federation components. (#6658) * Update generated ref docs for Kubernetes and Federation components. * Rename kubectl-options to kubectl. * Add title to kubectl. * Fix double synopsis. * Update Federation API ref docs for 1.9. (#6636) * Update federation API ref docs. * Move and redirect. * Move generated Federation docs to the generated directory. * Fix titles. * Type * Fix titles * Update auto-generated Kubernetes APi ref docs. (#6646) * Update kubectl commands for 1.9 (#6635) * add ExtendedResourceToleration admission controller (#6618) * Update API reference paths for v1.9 (#6681)

CRD Validation: remove alpha warning, change enable instructions to

5355ea0

disable

steveperry-53 self-assigned this Oct 26, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2017

steveperry-53 changed the base branch from master to release-1.9 October 26, 2017 20:44

steveperry-53 mentioned this pull request Oct 26, 2017

CRD Validation: remove alpha warning, change enable instructions to disable #6065

Closed

steveperry-53 changed the title ~~Dup~~ CRD Validation: remove alpha warning, change enable instructions to disable Oct 26, 2017

steveperry-53 added the Docs Review: Open Issues label Oct 26, 2017

nikhita reviewed Oct 26, 2017

View reviewed changes

steveperry-53 changed the title ~~CRD Validation: remove alpha warning, change enable instructions to disable~~ Custom Resource Validation: remove alpha warning, change enable instructions to disable Oct 27, 2017

steveperry-53 merged commit 3b85f60 into kubernetes:release-1.9 Nov 16, 2017

zacharysarah added Docs LGTM and removed Docs Review: Open Issues labels Nov 16, 2017

deads2k mentioned this pull request Nov 27, 2017

CustomResourceDefinitions kubernetes/enhancements#95

Closed

zacharysarah added this to In Progress in Release 1.9 Nov 27, 2017

zacharysarah moved this from In Progress to Done in Release 1.9 Nov 27, 2017

steveperry-53 deleted the dup branch November 29, 2017 02:19

This was referenced Nov 30, 2017

Release 1.9 #5978

Merged

[1.9] Issue Burndown kubernetes/sig-release#38

Closed

chenopis added the team/google label Aug 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Resource Validation: remove alpha warning, change enable instructions to disable #6066

Custom Resource Validation: remove alpha warning, change enable instructions to disable #6066

steveperry-53 commented Oct 26, 2017 •

edited

Loading

k8sio-netlify-preview-bot commented Oct 26, 2017

steveperry-53 commented Oct 26, 2017

colemickens commented Oct 26, 2017

steveperry-53 commented Oct 26, 2017

colemickens commented Oct 26, 2017 •

edited

Loading

steveperry-53 commented Oct 26, 2017

nikhita Oct 26, 2017 •

edited

Loading

colemickens Oct 27, 2017

nikhita Oct 27, 2017

nikhita commented Oct 26, 2017

nikhita commented Oct 26, 2017

nikhita commented Oct 26, 2017

colemickens commented Oct 27, 2017

colemickens commented Oct 27, 2017

nikhita commented Oct 27, 2017

colemickens commented Nov 10, 2017

colemickens commented Nov 15, 2017

colemickens commented Nov 16, 2017

Custom Resource Validation: remove alpha warning, change enable instructions to disable #6066

Custom Resource Validation: remove alpha warning, change enable instructions to disable #6066

Conversation

steveperry-53 commented Oct 26, 2017 • edited Loading

k8sio-netlify-preview-bot commented Oct 26, 2017

steveperry-53 commented Oct 26, 2017

colemickens commented Oct 26, 2017

steveperry-53 commented Oct 26, 2017

colemickens commented Oct 26, 2017 • edited Loading

steveperry-53 commented Oct 26, 2017

nikhita Oct 26, 2017 • edited Loading

Choose a reason for hiding this comment

colemickens Oct 27, 2017

Choose a reason for hiding this comment

nikhita Oct 27, 2017

Choose a reason for hiding this comment

nikhita commented Oct 26, 2017

nikhita commented Oct 26, 2017

nikhita commented Oct 26, 2017

colemickens commented Oct 27, 2017

colemickens commented Oct 27, 2017

nikhita commented Oct 27, 2017

colemickens commented Nov 10, 2017

colemickens commented Nov 15, 2017

colemickens commented Nov 16, 2017

steveperry-53 commented Oct 26, 2017 •

edited

Loading

colemickens commented Oct 26, 2017 •

edited

Loading

nikhita Oct 26, 2017 •

edited

Loading