Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change replicaset documentation to use apps/v1 API #6496

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

crimsonfaith91
Copy link
Contributor

@crimsonfaith91 crimsonfaith91 commented Nov 29, 2017

This PR changes replicaset documentation to use apps/v1 API.
/assign @kow3ns


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 29, 2017

Deploy preview ready!

Built with commit f292ac7

https://deploy-preview-6496--kubernetes-io-master-staging.netlify.com

@kow3ns
Copy link
Member

kow3ns commented Nov 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2017
@tengqm
Copy link
Contributor

tengqm commented Nov 30, 2017

@crimsonfaith91 Since this change is mostly about v1.9 changes, please consider rebase it on release-1.9 branch. Thanks.

@crimsonfaith91 crimsonfaith91 changed the base branch from master to release-1.9 November 30, 2017 07:25
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2017
@crimsonfaith91 crimsonfaith91 changed the base branch from release-1.9 to master November 30, 2017 07:25
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2017
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2017
@crimsonfaith91 crimsonfaith91 changed the base branch from master to release-1.9 November 30, 2017 18:17
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2017
@crimsonfaith91
Copy link
Contributor Author

@tengqm Done!

@tengqm tengqm merged commit c222729 into kubernetes:release-1.9 Dec 1, 2017
@zacharysarah zacharysarah added this to Done in Release 1.9 Dec 1, 2017
This was referenced Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants