Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local ephemeral storage feature to beta #7614

Closed
wants to merge 1 commit into from
Closed

Update local ephemeral storage feature to beta #7614

wants to merge 1 commit into from

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Mar 3, 2018 •
edited
Loading

update local ephemeral storage feature to beta

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 3, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5fc489f

https://deploy-preview-7614--kubernetes-io-master-staging.netlify.com

@jingxu97 jingxu97 mentioned this pull request Mar 3, 2018
Closed
@zhangxiaoyu-zidif
Copy link
Contributor

zhangxiaoyu-zidif commented Mar 3, 2018 •
edited
Loading

could you change this PR's base to release-1.0. =)
and suggest to delete 'and above'.
/cc @heckj

@heckj heckj added this to the 1.10 milestone Mar 3, 2018
heckj
heckj suggested changes Mar 3, 2018
View reviewed changes
Copy link
Contributor

@heckj heckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also target this PR against the branch release-1.10 since it's specific to the 1.10 release coming shortly.

docs/concepts/configuration/manage-compute-resources-container.md Outdated
@@ -306,7 +306,7 @@ LastState: map[terminated:map[exitCode:137 reason:OOM Killed startedAt:2015-07-0
You can see that the Container was terminated because of `reason:OOM Killed`,
where `OOM` stands for Out Of Memory.

## Local ephemeral storage (alpha feature)
## Local ephemeral storage (beta feature for version 1.10.0 and above)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change 1.10.0 to simply 1.10

@heckj
Copy link
Contributor

heckj commented Mar 3, 2018

/assign

@jingxu97
Update local ephemeral storage feature to beta
5fc489f 
update local ephemeral storage feature to beta
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: heckj

Assign the PR to them by writing /assign @heckj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tengqm
tengqm reviewed Mar 6, 2018
View reviewed changes
docs/concepts/configuration/manage-compute-resources-container.md
@@ -306,7 +306,7 @@ LastState: map[terminated:map[exitCode:137 reason:OOM Killed startedAt:2015-07-0
You can see that the Container was terminated because of `reason:OOM Killed`,
where `OOM` stands for Out Of Memory.

## Local ephemeral storage (alpha feature)
## Local ephemeral storage (beta feature for version 1.10 and above)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the parentheses completely and

  • add {% include feature-state-beta.md %} in a separate line
  • propose this to release-1.10 branch

tengqm
tengqm reviewed Mar 6, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check inline

@Bradamant3
Copy link
Contributor

@jingxu97 can you please get the requested changes in asap? Deadline for merging docs PRs for 1.10 is 3/9 (tomorrow US time).
/assign

@jingxu97
Copy link
Contributor Author

jingxu97 commented Mar 8, 2018

@Bradamant3
I rebased to release 1.10 and had another PR for it #7685

Is that one ok? Thanks!

@Bradamant3
Copy link
Contributor

All's good with #7685, so closing this one unmerged. Thanks, @jingxu97

@Bradamant3 Bradamant3 closed this Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@heckj heckj heckj requested changes

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees

@heckj heckj

@Bradamant3 Bradamant3

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jingxu97 @k8sio-netlify-preview-bot @zhangxiaoyu-zidif @heckj @k8s-ci-robot @Bradamant3 @tengqm