Update conventions.md #7668
Update conventions.md #7668
Conversation
Edited the content for better readability.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 88289a8 https://deploy-preview-7668--kubernetes-io-master-staging.netlify.com |
|
/assign @bgrant0607 |
k8s-ci-robot
added
the
lgtm
|
@Rajakavitha1 Thank you for your contribution. Please make sure to sign the CLA so we can accept the PR. |
|
cc @kubernetes/sig-cli-pr-reviews |
|
@bradtopol I signed the CLA. However, that does not get reflected in the checks |
k8s-ci-robot
added
cncf-cla: yes
|
/assign @bgrant0607 |
|
@Rajakavitha1 could you provide more context on why you made the grammatical changes that you did? Are you trying to adhere better to the style guidelines? It would help to have more context especially on the changes you feel very strongly about. |
|
@bradtopol You are right I edited the document for adherence to the style guide, word usage, and consistency. Hope that sets the context. |
|
If these are just grammatical and formatting changes, I don't think they need technical review. |
| Additionally, if you didn't specify a generator flag, other flags will suggest using | ||
| a specific generator. Below table shows which flags force using specific generators, | ||
| depending on your cluster version: | ||
| If you do not specify a generator flag, other flags prompts you to use a specific generator. The following table lists the flags that force you to use specific generators, depending on the version of the cluster: |
There was a problem hiding this comment.
flags prompts -> flags prompt
Formatted the {:note} to **Note:**
k8s-ci-robot
removed
the
lgtm
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heckj, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…elease-1.9 * 'master' of https://github.com/kubernetes/website: (549 commits) Update service.md (#7810) Prune inactive maintainers (#7830) add Amadeus to index page and add feature image (#7827) Update conventions.md (#7668) Adding Tenxcloud as KCSP and Hedvig typo (#7826) Update outdated documentation about secret key validation. (#7675) Update imperative-command.md (#7699) Update manage-deployment.md (#7774) Add the OCI runtime description. (#7769) fix flag (#7814) fix flag (#7813) Add files via upload (#7816) Remove CoreOS guide that use Kubernetes v0.15.0 (#7821) "Nagions" should be "Nagios“ (#7762) Update docker-cli-to-kubectl.md (#7748) adjust a note format (#7812) add a note when mount a configmap to pod (#7745) Make using sysctls a task instead of a concept (#6808) Partners page updates (#7802) Fix a missing word in endpoint reconciler section (#7804) ...
Edited the content for better readability.