Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Tutorials landing page and Tutorials left nav. #8557

Merged
merged 2 commits into from
May 15, 2018

Conversation

steveperry-53
Copy link
Contributor

@steveperry-53 steveperry-53 commented May 15, 2018

Closes #8247.

This PR moves some tutorial files to different directories, so that the left nav includes all tutorials. This PR also aligns the Tutorials landing page with the Tutorials left nav.

Preview: https://deploy-preview-8557--kubernetes-io-master-staging.netlify.com/docs/tutorials/

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 15, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4b7992f

https://deploy-preview-8557--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor Author

/assign @Bradamant3

@Bradamant3
Copy link
Contributor

this is beautiful

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2018
@steveperry-53
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@steveperry-53: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steveperry-53
Copy link
Contributor Author

@Bradamant3, The bot ate your LGTM. Could you do it again? Thanks.

@Bradamant3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2018
@Bradamant3
Copy link
Contributor

silly bot

@k8s-ci-robot k8s-ci-robot merged commit 21fd86e into kubernetes:master May 15, 2018
@steveperry-53 steveperry-53 deleted the tutorial-home branch May 16, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants