-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store summary cr objects #150
Conversation
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
…ry-CR-objects Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
…ry-CR-objects Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
PR Analysis
PR Feedback
How to use
|
Summary:
|
should you rebase this PR? it looks like it contains 13 commits for just a few changes, which is weird... |
PR Type:
Refactoring
PR Description:
This PR focuses on refactoring the summary object labels to lowercase. This includes the workload name, kind, and container name. The changes are reflected in both the main code and the corresponding tests.
PR Main Files Walkthrough:
repositories/apiserver.go
: The changes in this file involve converting the workload kind, name, and container name to lowercase using the strings.ToLower() function. This is done in the functions enrichSummaryManifestObjectLabels() and GetCVESummaryK8sResourceName().repositories/apiserver_test.go
: The changes in this file are related to the tests for the functions that were modified in the apiserver.go file. The expected results and input data for the tests have been updated to reflect the change to lowercase.User Description:
move summary object name and kind label to lower case