Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store summary cr objects #150

Closed
wants to merge 13 commits into from
Closed

Conversation

rcohencyberarmor
Copy link
Contributor

@rcohencyberarmor rcohencyberarmor commented Sep 3, 2023

PR Type:

Refactoring


PR Description:

This PR focuses on refactoring the summary object labels to lowercase. This includes the workload name, kind, and container name. The changes are reflected in both the main code and the corresponding tests.


PR Main Files Walkthrough:

repositories/apiserver.go: The changes in this file involve converting the workload kind, name, and container name to lowercase using the strings.ToLower() function. This is done in the functions enrichSummaryManifestObjectLabels() and GetCVESummaryK8sResourceName().
repositories/apiserver_test.go: The changes in this file are related to the tests for the functions that were modified in the apiserver.go file. The expected results and input data for the tests have been updated to reflect the change to lowercase.


User Description:

move summary object name and kind label to lower case

rcohencyberarmor added 13 commits August 16, 2023 14:37
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
…ry-CR-objects

Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
…ry-CR-objects

Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
@codiumai-pr-agent
Copy link

PR Analysis

  • 🎯 Main theme: Refactoring summary object labels to lowercase
  • 📝 PR summary: This PR focuses on refactoring the summary object labels to lowercase. This includes the workload name, kind, and container name. The changes are reflected in both the main code and the corresponding tests.
  • 📌 Type of PR: Refactoring
  • 🧪 Relevant tests added: Yes
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR seems well-structured and the changes are consistent across the codebase. The use of the strings.ToLower() function to convert the labels to lowercase is a good approach. However, it would be beneficial to ensure that this change does not affect any other parts of the codebase that may be case-sensitive.

  • 🤖 Code feedback:

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@rcohencyberarmor rcohencyberarmor added the release Create release label Sep 3, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@matthyx
Copy link
Contributor

matthyx commented Sep 4, 2023

should you rebase this PR? it looks like it contains 13 commits for just a few changes, which is weird...

@rcohencyberarmor rcohencyberarmor deleted the store-summary-CR-objects branch September 11, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants