Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated service discovery version #188

Merged
merged 2 commits into from
Nov 21, 2023
Merged

updated service discovery version #188

merged 2 commits into from
Nov 21, 2023

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Nov 21, 2023

PR Type:

Enhancement


PR Description:

This PR includes the following changes:

  • Upgraded the service discovery version from v1 to v2 in the backend services configuration.
  • Updated the dependency version of kubescape/backend in go.mod and go.sum files.

PR Main Files Walkthrough:

files:
  • config/config.go: Replaced the v1 service discovery with v2 in the LoadBackendServicesConfig function.
  • go.mod: Updated the version of kubescape/backend from v0.0.13 to v0.0.15.
  • go.sum: Added the new version of kubescape/backend (v0.0.15) and removed the old one (v0.0.13).

User Description:

Overview

Signed-off-by: Amir Malka <amirm@armosec.io>
@codiumai-pr-agent codiumai-pr-agent bot added the enhancement New feature or request label Nov 21, 2023
Copy link

PR Analysis

  • 🎯 Main theme: Upgrading service discovery version
  • 📝 PR summary: This PR upgrades the service discovery version from v1 to v2 in the backend services configuration. It also updates the dependency version of kubescape/backend in go.mod and go.sum files.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and involve updating versions and dependencies.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to include tests that verify the new service discovery version works as expected. Also, it would be helpful to provide more context about why this upgrade is necessary and what improvements or fixes it brings.

  • 🤖 Code feedback:

    • relevant file: config/config.go
      suggestion: Consider handling the case where the file path is empty in a more explicit way. Currently, if the path is empty, the function returns nil without any error or information. This could lead to confusion when debugging. [medium]
      relevant line: if path == "" {

    • relevant file: go.mod
      suggestion: Ensure that all other dependencies are compatible with the new version of kubescape/backend. [important]
      relevant line: github.com/kubescape/backend v0.0.15

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

Signed-off-by: Amir Malka <amirm@armosec.io>
@@ -14,6 +14,9 @@ concurrency:

jobs:
pr-created:
permissions:
pull-requests: write
security-events: write
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matthyx matthyx added the release Create release label Nov 21, 2023
Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@amirmalka amirmalka merged commit f5b8064 into main Nov 21, 2023
8 checks passed
@dwertent dwertent deleted the service-discovery-v2 branch December 13, 2023 11:01
dwertent pushed a commit that referenced this pull request Dec 31, 2023
* updated service discovery version

Signed-off-by: Amir Malka <amirm@armosec.io>

* fix workflow permissions

Signed-off-by: Amir Malka <amirm@armosec.io>

---------

Signed-off-by: Amir Malka <amirm@armosec.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release Create release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants