Update instruction for creating a new filter #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
✅ Deploy Preview for objective-jones-39e308 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mszostok
reviewed
Jun 6, 2022
mszostok
reviewed
Jun 6, 2022
mergify bot
pushed a commit
to kubeshop/botkube
that referenced
this pull request
Jun 6, 2022
…ve error handling #603 ##### ISSUE TYPE - Feature Pull Request ##### SUMMARY - Use envconfig - Remove global variables related to Kubernetes, logger, and filters - Pass context across all components - support graceful shutdown of all BotKube components - Improve error handling (return errors in almost all places instead of ignoring/logging them) This is just a start, as later (during new features development) we should refactor each component/package in isolation. But after this huge PR it should be possible to do it. Fixes #220 ##### TODO After first review of this PR if the new filter engine approach is accepted: - [x] Update documentation (https://www.botkube.io/filters/) PR: kubeshop/botkube-docs#81 ##### TESTING Tested manually with Mattermost, Discord and Slack. You can use the following image:`pkosiec/botkube:remove-global-vars-v2`
pkosiec
force-pushed
the
update-filter-guide
branch
from
59dcace
to
009ea34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR updates docs for PR kubeshop/botkube#603.
See kubeshop/botkube#603 and kubeshop/botkube#220 for more info.
Resolves kubeshop/botkube#220