Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help flag error, remove color codes #1231

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Sep 7, 2023

Description

Changes proposed in this pull request:

  • Fix help flag error, remove color codes

Testing

  1. env PLUGIN_SERVER_HOST=http://host.k3d.internal go run test/helpers/plugin_server.go
  2. PLUGIN_TARGETS="flux" make build-plugins-single
  3. Botkube config:
    communications:
      default-group:
        socketSlack:
          enabled: true
          channels:
            default:
              name: hakuna-matata
              bindings:
                sources: []
                executors:
                  - flux
          appToken: "xapp-1-"
          botToken: "xoxb-"
    
    
    executors:
      flux:
        botkube/flux:
          enabled: true
          config:
            log:
              level: "debug"
    
          context:
            rbac:
              group:
                type: Static
                static:
                  values: [ "system:masters" ]
    
    plugins:
      cacheDir: "/tmp/plugins"
    
      repositories:
        botkube:
          url: http://host.k3d.internal:3010/botkube.yaml
    
    settings:
      log:
        level: "debug"
        formatter: "text"
      clusterName: "labs"
      upgradeNotifier: false
    
    analytics:
      disable: true
    
    configWatcher:
      enabled: false
  4. Commands to run:
    @Botkube flux delete source git --help
    
    @Botkube flux create source git webapp-latest
       --url=https://github.com/stefanprodan/podinfo 
       --branch=master 
       --interval=3m
    
    @Botkube flux delete source git webapp-latest
    
    @Botkube flux delete source git webapp-latest -s
    

Screenshot 2023-09-07 at 10 13 15

Related issue(s)

Fix #1229

@mszostok mszostok added the bug Something isn't working label Sep 7, 2023
@mszostok mszostok force-pushed the fix-flux-bugs branch 2 times, most recently from ba74b48 to c8e70dd Compare September 7, 2023 08:17
@mszostok mszostok marked this pull request as ready for review September 7, 2023 08:18
@mszostok mszostok requested review from PrasadG193 and a team as code owners September 7, 2023 08:18
@pkosiec pkosiec self-assigned this Sep 7, 2023
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👌

internal/executor/flux/commands.go Outdated Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) September 7, 2023 10:02
@mszostok mszostok merged commit abfa1bc into kubeshop:main Sep 7, 2023
14 checks passed
@mszostok mszostok deleted the fix-flux-bugs branch September 7, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux plugin doesn't return help message
2 participants