Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams/integration tests #1361

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Teams/integration tests #1361

merged 13 commits into from
Jan 31, 2024

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jan 25, 2024

Description

Changes proposed in this pull request:

Follow-up issues

Testing

Overall testing approach:

  • events are sent directly to Pub/Sub as we are not able to ping bot
  • we sent a plaintext message to keep the conversation readable and inform what command was published into pub/sub
  • message assertion:
    • when we detect html msg we convert that to markdown and do use strings comparison
    • If attachment is sent, we render expected message into Adaptive Cards format and jsondiff library
    • If we assert a plaintext, we check if it is a message may contain a filter. If so, they are split into 2, and we need to fetch two last messages to get the "body".

Verified by CI:

another run but without first restart in Teams platform:

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Jan 25, 2024
test/go.mod Fixed Show fixed Hide fixed
test/go.mod Fixed Show fixed Hide fixed
@mszostok mszostok force-pushed the teams/integration-tests branch 7 times, most recently from 3693f69 to fa81694 Compare January 25, 2024 21:14
@mszostok mszostok force-pushed the teams/integration-tests branch 12 times, most recently from 48317d7 to 725a88e Compare January 29, 2024 16:23
@mszostok mszostok requested a review from pkosiec January 29, 2024 18:30
@mszostok mszostok marked this pull request as ready for review January 29, 2024 18:30
@mszostok mszostok requested review from PrasadG193 and a team as code owners January 29, 2024 18:30
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
@mszostok mszostok force-pushed the teams/integration-tests branch 3 times, most recently from de598a8 to 5d96daa Compare January 30, 2024 10:01
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🚀 Just some small comments.

.github/workflows/pr-build.yaml Show resolved Hide resolved
test/botkubex/botkube_cli_helpers.go Outdated Show resolved Hide resolved
test/go.mod Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/commplatform/teams_tester.go Outdated Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) January 31, 2024 09:01
@mszostok mszostok merged commit 68bfc25 into main Jan 31, 2024
17 of 19 checks passed
@mszostok mszostok deleted the teams/integration-tests branch January 31, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants