Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Plugins Report #1374

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

madebyrogal
Copy link
Collaborator

@madebyrogal madebyrogal commented Feb 7, 2024

Description

Changes proposed in this pull request:

  • Report to Segment plugins RBAC configuration

Testing

Related issue(s)

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments after code review 🙂 Didn't test it yet.

cmd/botkube-agent/main.go Outdated Show resolved Hide resolved
cmd/botkube-agent/main.go Show resolved Hide resolved
internal/analytics/segment_reporter.go Show resolved Hide resolved
internal/analytics/reporter.go Outdated Show resolved Hide resolved
internal/analytics/segment_reporter.go Outdated Show resolved Hide resolved
internal/analytics/segment_reporter.go Outdated Show resolved Hide resolved
cmd/botkube-agent/main.go Show resolved Hide resolved
internal/analytics/segment_reporter.go Outdated Show resolved Hide resolved
internal/analytics/segment_reporter.go Outdated Show resolved Hide resolved
@madebyrogal madebyrogal changed the title ADD PluginsConfigReport Add Enabled Plugins Report Feb 8, 2024
@madebyrogal madebyrogal changed the title Add Enabled Plugins Report Enabled Plugins Report Feb 8, 2024
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, I'm about to test the changes in next few minutes and approve it 👍

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Show resolved Hide resolved
internal/analytics/segment_reporter.go Outdated Show resolved Hide resolved
internal/analytics/segment_reporter_test.go Show resolved Hide resolved
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Good job!

@madebyrogal madebyrogal merged commit 45a6cd4 into kubeshop:main Feb 9, 2024
13 of 16 checks passed
@madebyrogal madebyrogal deleted the rbac-telemetry branch February 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants