Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building multi arch binaries for cli snapshot #1382

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Feb 12, 2024

Description

Changes proposed in this pull request:

  • Stop building multi arch binaries for CLI snapshot. For some reason, we built multi arch even though it's not needed and just make the e2e test longer.

Previous runs

Screenshot 2024-02-13 at 09 47 47 Screenshot 2024-02-13 at 09 48 20

Current runs

Screenshot 2024-02-13 at 09 47 51 Screenshot 2024-02-13 at 10 15 24

@mszostok mszostok added the enhancement New feature or request label Feb 12, 2024
@mszostok mszostok marked this pull request as ready for review February 13, 2024 08:40
@mszostok mszostok requested review from PrasadG193 and a team as code owners February 13, 2024 08:40
@mszostok mszostok requested a review from vaijab February 13, 2024 08:40
@@ -64,8 +64,11 @@ container-image-single: pre-build
release-snapshot:
@./hack/goreleaser.sh release_snapshot

build-single-arch-cli:
@./hack/goreleaser.sh build_single_arch_cli

release-snapshot-cli:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to stay because of the pull_request_target that always uses the job manifest from main. I will remove it in my next PR after merging this one.

Copy link
Collaborator

@vaijab vaijab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Great stuff.

@mszostok mszostok merged commit 2e1a39d into kubeshop:main Feb 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants