Add teams and slack parent activity id support, remove not used activityId field from gRPC #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ityId field from gRPC
mszostok
force-pushed
the
teams-and-slack-parent-id
branch
from
837aeb3
to
58b6d24
Compare
pkosiec
approved these changes
Feb 20, 2024
| @@ -16,7 +16,6 @@ enum MessageType { | |||
|
|
|||
| message Message { | |||
| string teamId = 1; | |||
| string activityId = 2; | |||
There was a problem hiding this comment.
It's ok to remove the field as we updated the plugin contract version recently. Is that correct?
There was a problem hiding this comment.
it's about cloud_teams, so it is not related, it's only about control-plane <-> agent communication. They should work properly as this field was not used anyway 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
activityIdfield from gRPCRelated issue(s)
fix https://github.com/kubeshop/botkube-cloud/issues/890