Extract plugins and delete legacy platforms #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
extract-plugins-and-delete-legacy-platforms
branch
from
a9f9293
to
b302913
Compare
pkosiec
requested review from
madebyrogal and
mszostok
and removed request for
madebyrogal
|
I'll revert all "FIXME" places before merge 👍 |
mszostok
approved these changes
Feb 22, 2024
| @@ -60,23 +60,6 @@ rbac: | |||
| - apiGroups: ["*"] | |||
| resources: ["*"] | |||
| verbs: ["get", "watch", "list"] | |||
| 'argocd': | |||
There was a problem hiding this comment.
Should we move all those removed configurations to the docs as examples? Since we now have a YAML config editor, it will be easy to copy them over after configuring them through the UI.
There was a problem hiding this comment.
Yes, good idea. As a part of the documentation task I'll update:
- instructions how to create RBAC group
- examples for plugin configuration
👍
mszostok
reviewed
Feb 22, 2024
pkosiec
force-pushed
the
extract-plugins-and-delete-legacy-platforms
branch
from
80edb36
to
1b688fb
Compare
vember31
referenced
this pull request
in vember31/home-ops
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
kubectlandkubernetes, and the test onesReason
Botkube is introducing new plugins with advanced functionality that will be part of the Botkube Team and Enterprise packages. These advanced plugins require cloud services provided by Botkube and are not part of the Botkube open source software.
As part of this change, some of the existing Botkube plugins are being moved to a new repository. This repository requires authentication with a Botkube account. To continue using these Botkube plugins, create an account at https://app.botkube.io/ and configure a Botkube instance, or migrate an existing installation with the Botkube CLI.