Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executor assertion for integration tests #1397

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Feb 23, 2024

Description

Changes proposed in this pull request:

  • Fix executor assertion for integration tests

This is caused by the migration update on dev. During first startup of Botkube, we're dropping the plugin version. That's why we need to update the assertion.

@pkosiec pkosiec marked this pull request as ready for review February 23, 2024 15:19
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners February 23, 2024 15:19
@pkosiec pkosiec requested a review from vaijab February 23, 2024 15:19
@pkosiec pkosiec added ci Related to CI pipelines other Internal, no user-facing changes. labels Feb 23, 2024
@pkosiec pkosiec changed the title Fix executor assertion Fix executor assertion for integration tests Feb 23, 2024
@pkosiec pkosiec added this to the v1.9.0 milestone Feb 23, 2024
@pkosiec pkosiec merged commit a744a14 into kubeshop:main Feb 23, 2024
20 of 21 checks passed
@pkosiec pkosiec deleted the fix-integration-tests branch February 23, 2024 15:45
mszostok pushed a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to CI pipelines other Internal, no user-facing changes.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants