Fix Helm chart upgrade when lookup is not supported
#1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
fix-helm-chart-lookup
branch
from
6354c75
to
c07e5aa
Compare
|
Tested this on our test cluster, and ArgoCD was able to successfully deploy it |
vaijab
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
lookupis not supportedTesting
I don't think it's needed to test it but if you want to, see the instruction from #1274
Related issue(s)
See conversation: https://botkube.slack.com/archives/C01CR1KS55K/p1709740107856559
See also: #1376