Only log incorrect k8s buttons definitions

[mszostok]

Description

Changes proposed in this pull request:

• Only log incorrect k8s buttons definitions
• Agent without debug enabled, shows k8s plugin errors too.

Testing

You can see the unit-test, additionally I tested that e2e:

• when Agent uses text logger:

  ERRO[2024-03-11T18:17:30+01:00] ERRO[2024-03-11T18:17:30+01:00] Failed to convert extra buttons assigned to "error" event. Those buttons will be omitted. Issues:  logger=stderr plugin=botkube/kubernetes
  ERRO[2024-03-11T18:17:30+01:00] 3 errors occurred:                            logger=stderr plugin=botkube/kubernetes
  ERRO[2024-03-11T18:17:30+01:00] 	* invalid extraButtons[1].commandTpl: template: Ask AI v2:1:11: executing "Ask AI v2" at <.Event.Namespace>: can't evaluate field Event in type event.Event  logger=stderr plugin=botkube/kubernetes
  ERRO[2024-03-11T18:17:30+01:00] 	* invalid extraButtons[2]: displayName cannot be empty  logger=stderr plugin=botkube/kubernetes
  ERRO[2024-03-11T18:17:30+01:00] 	* invalid extraButtons[3]: displayName cannot be empty, unknown trigger.type["fatal"]  component="Message Builder"  logger=stderr plugin=botkube/kubernetes
  

• when agent uses json logger:

  {"level":"error","logger":"stderr","msg":"\u001b[31mERRO\u001b[0m[2024-03-11T18:37:36+01:00] Failed to convert extra buttons assigned to \"error\" event. Those buttons will be omitted. Issues:","plugin":"botkube/kubernetes","time":"2024-03-11T18:37:36+01:00"}
  {"level":"error","logger":"stderr","msg":"3 errors occurred:","plugin":"botkube/kubernetes","time":"2024-03-11T18:37:36+01:00"}
  {"level":"error","logger":"stderr","msg":"\t* invalid extraButtons[1].commandTpl: template: Ask AI v2:1:11: executing \"Ask AI v2\" at \u003c.Event.Namespace\u003e: can't evaluate field Event in type event.Event","plugin":"botkube/kubernetes","time":"2024-03-11T18:37:36+01:00"}
  {"level":"error","logger":"stderr","msg":"\t* invalid extraButtons[2]: displayName cannot be empty","plugin":"botkube/kubernetes","time":"2024-03-11T18:37:36+01:00"}
  {"level":"error","logger":"stderr","msg":"\t* invalid extraButtons[3]: displayName cannot be empty, unknown trigger.type[\"fatal\"]  \u001b[31mcomponent\u001b[0m=\"Message Builder\"","plugin":"botkube/kubernetes","time":"2024-03-11T18:37:36+01:00"}

1. Checkout PR

2. Build plugin: PLUGIN_TARGETS="kubernetes" make build-plugins-single

3. Start server: make serve-local-plugins

4. Start Botkube Agent with such configuration:

   Config

   communications:
     default-group:
       socketSlack:
         enabled: true
         channels:
           default:
             name: hakuna-matata
             bindings:
               sources:
                 - k8s-ai-support-err-events
               executors: []
         appToken: "xapp-1-"
         botToken: "xoxb-"
   
   sources:
     'k8s-ai-support-err-events':
       displayName: "K8s AI-powered errors"
       botkube/kubernetes:
         enabled: true
         context:
           defaultNamespace: "default"
           rbac:
             group:
               type: Static
               static:
                 values: [ "botkube-plugins-default" ]
         config:
           # -- Define extra buttons to be displayed beside notification message.
           extraButtons:
             - enabled: true
               trigger:
                 type: [ "ERROR" ]
               button:
                 displayName: "Ask AI"
                 commandTpl: "ai --resource={{ .Namespace }}/{{ .Kind | lower }}/{{ .Name }} --error={{ .Reason }} --bk-cmd-header='AI assistance'"
             - enabled: true
               trigger:
                 type: [ "error" ]
               button:
                 displayName: "Ask AI v2"
                 commandTpl: "ai {{.Event.Namespace}} this one is wrong"
   
             - enabled: true
               trigger:
                 type: [ "error" ]
               button:
                 commandTpl: "ai {{.Event.Namespace}} this one is wrong"
   
             - enabled: true
               trigger:
                 type: [ "fatal" ]
               button:
                 commandTpl: "ai {{.Event.Namespace}} this one is wrong"
   
           namespaces:
             include:
               - ".*"
           event:
             types:
               - error
           resources:
             - type: v1/pods
   
   plugins:
     cacheDir: "/tmp/plugins"
     repositories:
       botkube:
         url: http://localhost:3010/botkube.yaml
   
   settings:
     log:
       level: "info"
       formatter: text
     kubeconfig: "your kubeconfig path"
     clusterName: "labs"
     upgradeNotifier: false
   
   analytics:
     disable: true

You should still get Pods error, if you will try the same on main, it won't get you a notification.

Related issue(s)

Fix #1407

[vaijab]

Nice one!