Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Teams integration tests assertions #1429

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix Teams integration tests assertions #1429

merged 1 commit into from
Apr 9, 2024
+22 −35

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Apr 8, 2024 •
edited

@mszostok mszostok added the bug Something isn't working label Apr 8, 2024
@mszostok mszostok added the ci Related to CI pipelines label Apr 8, 2024
@mszostok mszostok changed the title Fix MS Teams integration tests Fix Teams integration tests assertions Apr 8, 2024
@mszostok mszostok mentioned this pull request Apr 8, 2024
Closed
@mszostok mszostok marked this pull request as ready for review April 8, 2024 10:49
@mszostok mszostok requested review from PrasadG193 and a team as code owners April 8, 2024 10:49
@mszostok mszostok requested a review from vaijab April 8, 2024 10:49
pkosiec
pkosiec approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mszostok mszostok merged commit 9bd883c into kubeshop:main Apr 9, 2024
19 checks passed
@mszostok mszostok deleted the teams-test branch April 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

@vaijab vaijab Awaiting requested review from vaijab vaijab is a code owner automatically assigned from kubeshop/botkube-dev

Assignees
No one assigned
Labels
bug Something isn't working ci Related to CI pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft Teams integration tests fail on plaintext messages
2 participants
@mszostok @pkosiec