Enhance Update Events with resource spec diff and Change event message formats #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenio
force-pushed
the
feature/update-events
branch
from
c26e9ad
to
b804b3c
Compare
PrasadG193
reviewed
Aug 17, 2019
|
@aananthraj could you please also verify if |
codenio
force-pushed
the
feature/update-events
branch
from
b804b3c
to
dcf2492
Compare
|
@PrasadG193, Resolved those issues 👍 |
codenio
force-pushed
the
feature/update-events
branch
from
dcf2492
to
99fe4e2
Compare
This Commit - includes namespace field only for namespaced objects notifs - excludes namespace field from namespace independent resource events
This Commit, - enhances update event notifications with details of what Spec is getting changed - adds custom `SpecDiffReporter` and `utils.Diff()` method. - adds update events in all config.yaml files - adds unit-test for utils.Diff() - adds update events for Deployment, Statefulset and Job by default.
codenio
force-pushed
the
feature/update-events
branch
from
99fe4e2
to
4dc0051
Compare
PrasadG193
approved these changes
Aug 18, 2019
|
Awesome! Great work @aananthraj 🎉 |
|
Thanks for the excellent support @PrasadG193 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This PR,
SpecDiffReporterandutils.Diff()method.Fixes #131
Preview
Fixes #135
Preview
Fixes excludes namespace field from namespace independent resource events
Preview