-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send bot start/stop messages to slack channel #3
Merged
+112
−35
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
package controller | ||
|
||
import ( | ||
//"fmt" | ||
"os" | ||
"os/signal" | ||
"strconv" | ||
"strings" | ||
"syscall" | ||
"time" | ||
|
||
"github.com/infracloudio/kubeops/pkg/config" | ||
"github.com/infracloudio/kubeops/pkg/events" | ||
"github.com/infracloudio/kubeops/pkg/filterengine" | ||
"github.com/infracloudio/kubeops/pkg/logging" | ||
log "github.com/infracloudio/kubeops/pkg/logging" | ||
"github.com/infracloudio/kubeops/pkg/notify" | ||
"github.com/infracloudio/kubeops/pkg/utils" | ||
|
||
|
@@ -34,10 +34,23 @@ func findNamespace(ns string) string { | |
|
||
// RegisterInformers creates new informer controllers to watch k8s resources | ||
func RegisterInformers(c *config.Config) { | ||
sendMessage("...and now my watch begins! :crossed_swords:") | ||
startTime = time.Now().Local() | ||
|
||
// Get resync period | ||
rsyncTimeStr, ok := os.LookupEnv("INFORMERS_RESYNC_PERIOD") | ||
if !ok { | ||
rsyncTimeStr = "30" | ||
} | ||
|
||
rsyncTime, err := strconv.Atoi(rsyncTimeStr) | ||
if err != nil { | ||
log.Logger.Fatal("Error in reading INFORMERS_RESYNC_PERIOD env var.", err) | ||
} | ||
|
||
// Register informers for resource lifecycle events | ||
if len(c.Resources) > 0 { | ||
logging.Logger.Info("Registering resource lifecycle informer") | ||
log.Logger.Info("Registering resource lifecycle informer") | ||
for _, r := range c.Resources { | ||
if _, ok := utils.ResourceGetterMap[r.Name]; !ok { | ||
continue | ||
|
@@ -47,15 +60,15 @@ func RegisterInformers(c *config.Config) { | |
continue | ||
} | ||
for _, ns := range r.Namespaces { | ||
logging.Logger.Infof("Adding informer for resource:%s namespace:%s", r.Name, ns) | ||
log.Logger.Infof("Adding informer for resource:%s namespace:%s", r.Name, ns) | ||
|
||
watchlist := cache.NewListWatchFromClient( | ||
utils.ResourceGetterMap[r.Name], r.Name, findNamespace(ns), fields.Everything()) | ||
|
||
_, controller := cache.NewInformer( | ||
watchlist, | ||
object, | ||
30*time.Minute, | ||
time.Duration(rsyncTime)*time.Minute, | ||
registerEventHandlers(r.Name, r.Events), | ||
) | ||
stopCh := make(chan struct{}) | ||
|
@@ -69,14 +82,14 @@ func RegisterInformers(c *config.Config) { | |
|
||
// Register informers for k8s events | ||
if len(c.Events.Types) > 0 { | ||
logging.Logger.Info("Registering kubernetes events informer") | ||
log.Logger.Info("Registering kubernetes events informer") | ||
watchlist := cache.NewListWatchFromClient( | ||
utils.KubeClient.CoreV1().RESTClient(), "events", apiV1.NamespaceAll, fields.Everything()) | ||
|
||
_, controller := cache.NewInformer( | ||
watchlist, | ||
&apiV1.Event{}, | ||
30*time.Minute, | ||
time.Duration(rsyncTime)*time.Minute, | ||
cache.ResourceEventHandlerFuncs{ | ||
AddFunc: func(obj interface{}) { | ||
key, err := cache.MetaNamespaceKeyFunc(obj) | ||
|
@@ -89,12 +102,12 @@ func RegisterInformers(c *config.Config) { | |
ns := eventObj.InvolvedObject.Namespace | ||
eType := strings.ToLower(eventObj.Type) | ||
|
||
logging.Logger.Debugf("Received event: kind:%s ns:%s type:%s", kind, ns, eType) | ||
log.Logger.Debugf("Received event: kind:%s ns:%s type:%s", kind, ns, eType) | ||
// Filter and forward | ||
if (utils.AllowedEventKindsMap[utils.EventKind{kind, "all"}] || | ||
utils.AllowedEventKindsMap[utils.EventKind{kind, ns}]) && (utils.AllowedEventTypesMap[eType]) { | ||
logging.Logger.Infof("Processing add to events: %s. Invoked Object: %s:%s", key, eventObj.InvolvedObject.Kind, eventObj.InvolvedObject.Namespace) | ||
logEvent(obj, "events", "create", err) | ||
log.Logger.Infof("Processing add to events: %s. Invoked Object: %s:%s", key, eventObj.InvolvedObject.Kind, eventObj.InvolvedObject.Namespace) | ||
sendEvent(obj, "events", "create", err) | ||
} | ||
}, | ||
}, | ||
|
@@ -109,56 +122,65 @@ func RegisterInformers(c *config.Config) { | |
signal.Notify(sigterm, syscall.SIGTERM) | ||
signal.Notify(sigterm, syscall.SIGINT) | ||
<-sigterm | ||
|
||
sendMessage("my watch has ended!") | ||
} | ||
|
||
func registerEventHandlers(resourceType string, events []string) (handlerFns cache.ResourceEventHandlerFuncs) { | ||
for _, event := range events { | ||
if event == "all" || event == "create" { | ||
handlerFns.AddFunc = func(obj interface{}) { | ||
key, err := cache.MetaNamespaceKeyFunc(obj) | ||
logging.Logger.Debugf("Processing add to %v: %s", resourceType, key) | ||
logEvent(obj, resourceType, "create", err) | ||
log.Logger.Debugf("Processing add to %v: %s", resourceType, key) | ||
sendEvent(obj, resourceType, "create", err) | ||
} | ||
} | ||
|
||
if event == "all" || event == "update" { | ||
handlerFns.UpdateFunc = func(old, new interface{}) { | ||
key, err := cache.MetaNamespaceKeyFunc(new) | ||
logging.Logger.Debugf("Processing update to %v: %s", resourceType, key) | ||
logEvent(new, resourceType, "update", err) | ||
log.Logger.Debugf("Processing update to %v: %s", resourceType, key) | ||
sendEvent(new, resourceType, "update", err) | ||
} | ||
} | ||
|
||
if event == "all" || event == "delete" { | ||
handlerFns.DeleteFunc = func(obj interface{}) { | ||
key, err := cache.MetaNamespaceKeyFunc(obj) | ||
logging.Logger.Debugf("Processing delete to %v: %s", resourceType, key) | ||
logEvent(obj, resourceType, "delete", err) | ||
log.Logger.Debugf("Processing delete to %v: %s", resourceType, key) | ||
sendEvent(obj, resourceType, "delete", err) | ||
} | ||
} | ||
} | ||
return handlerFns | ||
} | ||
|
||
func logEvent(obj interface{}, kind, eventType string, err error) { | ||
func sendEvent(obj interface{}, kind, eventType string, err error) { | ||
if err != nil { | ||
logging.Logger.Error("Error while receiving event: ", err.Error()) | ||
log.Logger.Error("Error while receiving event: ", err.Error()) | ||
return | ||
} | ||
|
||
// Skip older events | ||
if eventType == "create" { | ||
objectMeta := utils.GetObjectMetaData(obj) | ||
if objectMeta.CreationTimestamp.Sub(startTime).Seconds() <= 0 { | ||
logging.Logger.Debug("Skipping older events") | ||
log.Logger.Debug("Skipping older events") | ||
return | ||
} | ||
} | ||
|
||
// Skip older events | ||
if eventType == "delete" { | ||
objectMeta := utils.GetObjectMetaData(obj) | ||
if objectMeta.DeletionTimestamp.Sub(startTime).Seconds() <= 0 { | ||
log.Logger.Debug("Skipping older events") | ||
return | ||
} | ||
} | ||
|
||
// Check if Notify disabled | ||
if !config.Notify { | ||
logging.Logger.Info("Skipping notification") | ||
log.Logger.Info("Skipping notification") | ||
return | ||
} | ||
|
||
|
@@ -168,5 +190,14 @@ func logEvent(obj interface{}, kind, eventType string, err error) { | |
|
||
// Send notification to communication chennel | ||
notifier := notify.NewSlack() | ||
notifier.Send(event) | ||
notifier.SendEvent(event) | ||
} | ||
|
||
func sendMessage(msg string) { | ||
if len(msg) <= 0 { | ||
return | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. log warning here |
||
} | ||
|
||
notifier := notify.NewSlack() | ||
notifier.SendMessage(msg) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this function in notifier package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssudake21 we already have
notifier.SendMessage(msg)
function in notifier package