Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Mattermost #55

Merged
merged 1 commit into from Mar 29, 2019
Merged

Add support for Mattermost #55

merged 1 commit into from Mar 29, 2019

Conversation

mugdha-adhav
Copy link
Contributor

No description provided.

@mugdha-adhav mugdha-adhav changed the title Issue #26: Design doc for Mattermost support WIP Issue #26: Design doc for Mattermost support Mar 19, 2019
sanketsudake
sanketsudake reviewed Mar 22, 2019
View reviewed changes
helm/botkube/values.yaml Outdated Show resolved Hide resolved
pkg/mattermost/mattermost.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/mattermost/mattermost.go Outdated Show resolved Hide resolved
Gopkg.lock Show resolved Hide resolved
@sanketsudake
Copy link
Contributor

@mugdha-adhav Lets rebase this once with PR #59 . Seeing lot of duplicate changes. Will check all changes in one go

@sanketsudake sanketsudake mentioned this pull request Mar 25, 2019
Closed
@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch 2 times, most recently from 82b1d0b to cccae3d Compare March 25, 2019 13:09
@mugdha-adhav mugdha-adhav changed the title WIP Issue #26: Design doc for Mattermost support Add support for Mattermost Mar 25, 2019
@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from cccae3d to 6f343f4 Compare March 25, 2019 20:52
@PrasadG193
Copy link
Collaborator

@mugdha-adhav please update https://github.com/infracloudio/botkube/blob/infracloudio/mattermost-support/deploy-all-in-one.yaml with the configuration changes

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 6f343f4 to 616d80b Compare March 26, 2019 20:06
@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch 2 times, most recently from 858b2d9 to fee50d0 Compare March 28, 2019 06:35
@PrasadG193
Copy link
Collaborator

PrasadG193 commented Mar 28, 2019 •
edited

@mugdha-adhav not a part of this PR, but could you please remove func formatAndSendLogs(rtm *slack.RTM, channelID, logs string, filename string) function, I don't think we need that anymore.
https://github.com/infracloudio/botkube/blob/master/pkg/slack/slack.go#L119

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from fee50d0 to 0fd452f Compare March 28, 2019 21:06
sanketsudake
sanketsudake reviewed Mar 29, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 0fd452f to 71cd575 Compare March 29, 2019 06:37
@sanketsudake sanketsudake merged commit 133af07 into develop Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

@PrasadG193 PrasadG193 PrasadG193 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mugdha-adhav @sanketsudake @PrasadG193