Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default helm namespace, update helm help #921

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add default helm namespace, update helm help #921

merged 1 commit into from
Jan 9, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jan 9, 2023 •
edited

Description

Changes proposed in this pull request:

  • Add default helm namespace. By default, (when -n/--namespace is not provided) the Helm CLI used the namespace where Botkube was deployed and not the default one.
  • Update helm help

Testing

  1. Global Help

    @Botkube helm help
@Botkube helm --help

  2. Install (default and test namespace)

    @Botkube helm install -h

# By absolute URL:
@Botkube helm install
  --repo https://charts.bitnami.com/bitnami psql postgresql
  --set clusterDomain='testing.local'

# By chart reference:
@Botkube helm install https://charts.bitnami.com/bitnami/postgresql-12.1.0.tgz --create-namespace -n test --generate-name

  3. List (default and all namespaces)

    @Botkube helm list
@Botkube helm list -A
@Botkube helm list -f 'p' -A

  4. Upgrade (default namespace)

    @Botkube helm upgrade --repo https://charts.bitnami.com/bitnami psql postgresql --set clusterDomain='cluster.local'

@mszostok mszostok added the bug Something isn't working label Jan 9, 2023
@mszostok mszostok requested review from a team and PrasadG193 as code owners January 9, 2023 08:33
josefkarasek
josefkarasek approved these changes Jan 9, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mszostok mszostok merged commit 14ec1e0 into kubeshop:main Jan 9, 2023
@mszostok mszostok deleted the helm-history-and-namespace branch January 9, 2023 09:08
josefkarasek pushed a commit to josefkarasek/botkube that referenced this pull request Jan 9, 2023
@mszostok
Add default helm namespace, update helm help (kubeshop#921)
0285e82
josefkarasek pushed a commit that referenced this pull request Jan 9, 2023
@mszostok @pkosiec
Cherry-pick bug fixes for 0.17 (#926)
87e2497 
* Add default helm namespace, update helm help (#921)

* Fix marshalling event for Elasticsearch integration (#923)

Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
Co-authored-by: Pawel Kosiec <pawel.kosiec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mszostok @josefkarasek