Upload plugins to GCS #944
Conversation
josefkarasek
force-pushed
the
push-plugins
branch
2 times, most recently
from
9b249c9
to
9f30346
Compare
|
Hey @josefkarasek, please post the links to sample runs of this Job on your fork (as a proof this works as expected). Thanks! |
There was a problem hiding this comment.
Generally LGTM, good work! 👍 Just minor comments.
Also, I know we're also building these plugins for integration test purposes, so theoretically we could extend that workflow, but building plugins is fast and I think a separate workflow like you did is much easier to maintain 👍
| publish_plugins: | ||
| permissions: | ||
| contents: 'read' | ||
| id-token: 'write' |
| version: latest | ||
| - name: Build all plugins into dist directory | ||
| env: | ||
| GORELEASER_CURRENT_TAG: "v1.0.0-devel" |
There was a problem hiding this comment.
🤔 I know we used this for integration tests, but this is different case, because the version is public. Can we change this v9.99.9-dev? It's not that I like v9.99.9-dev tag, but just for consistency reason it would be better than 1.0.0. Somebody can think we're going to release 1.0.0 soon 😄
Other ideas: v0.0.0-latest, v0.0.0-dev... but probably consistency is better.
What do you think?
PS you can also change the version for the integration tests.
There was a problem hiding this comment.
I there any place in the test where the version is also hard-coded?
There was a problem hiding this comment.
Yes, branch + PR build, but you already changed 👍
josefkarasek
force-pushed
the
push-plugins
branch
from
d5791aa
to
3196c52
Compare
There was a problem hiding this comment.
Before merge, can you run this job once again just to make sure it works properly? I think the content: read permission is necessary (I wanted to remove id_token: write). But let's make sure it works before merge 👍 You can post a link to successful job here. Thanks!
josefkarasek
force-pushed
the
push-plugins
branch
from
3196c52
to
2fdfd82
Compare
|
For example this run: https://github.com/kubeshop/botkube/actions/runs/3949008561/workflow |
josefkarasek
force-pushed
the
push-plugins
branch
from
f2fedb1
to
9db87dc
Compare
Description
Changes proposed in this pull request:
Resolves #943