Support fetching plugin dependencies #950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
go-getter
PLUGIN_DEPENDENCY_DIR
env variable to the plugins to use fetched dependenciesTesting
No need to test it manually - the current integration tests prove the functionality works as expected. Helm binary is no longer there in the Botkube Docker image, but the integration tests still pass.
However, if you'd like to, then follow the tutorial here: https://docs.botkube.io/plugin/local-testing
I used the following file as the
/tmp/config-values.yaml
:In
botkube
repo, run:Then in a new terminal run:
I hope you have different Helm version installed on your system - if not, upgrade it locally to anything different than v3.6.3 (e.g. 3.10+) 馃槃
Once Botkube is run, run
@Botkube helm version
on thebotkube-demo
channel to see the Helm version used. The output should be equal to:Related PRs:
kubeshop/botkube-docs#203
Related issue(s)
#899